From 3955cae0c5241f5a67b15a3da2cd524c3839f8c9 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Mon, 26 Nov 2018 10:49:49 +0900 Subject: [PATCH] Fix regression test handling of test_decoding with MSVC The set of scripts in charge of running the regression tests for MSVC run currently under the assumption that only $(top_builddir) can used in option values defined in REGRESS_OPTS, and those options need to have a specific format as well to be correctly parsed, so fix the Makefile values so as those are correctly set. Per complains from buildfarm member dory and whelk, with some extra testing done on my side with MSVC to check this patch. --- contrib/test_decoding/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/test_decoding/Makefile b/contrib/test_decoding/Makefile index 8cd83a763f..06af254f1d 100644 --- a/contrib/test_decoding/Makefile +++ b/contrib/test_decoding/Makefile @@ -11,8 +11,8 @@ REGRESS = ddl xact rewrite toast permissions decoding_in_xact \ ISOLATION = mxact delayed_startup ondisk_startup concurrent_ddl_dml \ oldest_xmin snapshot_transfer -REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/test_decoding/logical.conf -ISOLATION_OPTS = --temp-config $(top_srcdir)/contrib/test_decoding/logical.conf +REGRESS_OPTS = --temp-config=$(top_builddir)/contrib/test_decoding/logical.conf +ISOLATION_OPTS = --temp-config=$(top_builddir)/contrib/test_decoding/logical.conf # Disabled because these tests require "wal_level=logical", which # typical installcheck users do not have (e.g. buildfarm clients).