mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-06 13:07:10 +02:00
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.
The additional newline seems to have accidentally been introduced in2c03216d83
, in 9.5. The newline is only issued when an FPW is present for the block reference. While there could be an argument that removing the newlines in the back branches could cause a problem for somebody parsing the pg_waldump output, the likelihood of that seems small enough. It seems at least equally likely that the randomness of when newlines are issued causes problems. Author: Andres Freund Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de Backpatch: 9.5, like2c03216d83
.
This commit is contained in:
parent
af67aee691
commit
3b24cf732e
@ -609,7 +609,7 @@ XLogDumpDisplayRecord(XLogDumpConfig *config, XLogReaderState *record)
|
||||
BKPIMAGE_IS_COMPRESSED)
|
||||
{
|
||||
printf(" (FPW%s); hole: offset: %u, length: %u, "
|
||||
"compression saved: %u\n",
|
||||
"compression saved: %u",
|
||||
XLogRecBlockImageApply(record, block_id) ?
|
||||
"" : " for WAL verification",
|
||||
record->blocks[block_id].hole_offset,
|
||||
@ -620,7 +620,7 @@ XLogDumpDisplayRecord(XLogDumpConfig *config, XLogReaderState *record)
|
||||
}
|
||||
else
|
||||
{
|
||||
printf(" (FPW%s); hole: offset: %u, length: %u\n",
|
||||
printf(" (FPW%s); hole: offset: %u, length: %u",
|
||||
XLogRecBlockImageApply(record, block_id) ?
|
||||
"" : " for WAL verification",
|
||||
record->blocks[block_id].hole_offset,
|
||||
|
Loading…
Reference in New Issue
Block a user