From 3b8d7215533ed3128b1b9174eae830d70c0453d0 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 2 Mar 2016 01:06:31 -0500 Subject: [PATCH] Fix TAP tests for older Perls. Commit 7132810c (Retain tempdirs for failed tests) used Test::More's is_passing method, but that was added in Test::More 0.89_01 which is sometime later than Perl 5.10.1. Popular platforms such as RHEL6 don't have that, nevermind some of our older dinosaurs. Do it the hard way. Michael Paquier, based on research by Craig Ringer --- src/test/perl/TestLib.pm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm index 4fb43fee21..564936e5e5 100644 --- a/src/test/perl/TestLib.pm +++ b/src/test/perl/TestLib.pm @@ -110,7 +110,17 @@ INIT END { # Preserve temporary directory for this test on failure - $File::Temp::KEEP_ALL = 1 unless Test::More->builder->is_passing; + $File::Temp::KEEP_ALL = 1 unless all_tests_passing(); +} + +sub all_tests_passing +{ + my $fail_count = 0; + foreach my $status (Test::More->builder->summary) + { + return 0 unless $status; + } + return 1; } #