From 3c551ebede46194237f82062b54b92e474b5c743 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 7 Nov 2023 07:58:14 +0100 Subject: [PATCH] citext: Allow tests to pass in OpenSSL FIPS mode citext doesn't define an md5() function, so the value of using it in its tests is dubious. At best this shows in an indirect way that the cast from citext to text works. Avoid the issue and remove the test. Discussion: https://www.postgresql.org/message-id/flat/dbbd927f-ef1f-c9a1-4ec6-c759778ac852%40enterprisedb.com --- contrib/citext/expected/citext.out | 9 --------- contrib/citext/expected/citext_1.out | 9 --------- contrib/citext/sql/citext.sql | 1 - 3 files changed, 19 deletions(-) diff --git a/contrib/citext/expected/citext.out b/contrib/citext/expected/citext.out index 1c55598136..8c0bf54f0f 100644 --- a/contrib/citext/expected/citext.out +++ b/contrib/citext/expected/citext.out @@ -1744,15 +1744,6 @@ SELECT ltrim('zzzytrim'::citext, 'xyz'::text ) = 'trim' AS t; t (1 row) -SELECT md5( name ) = md5( name::text ) AS t FROM srt; - t ---- - t - t - t - t -(4 rows) - -- pg_client_encoding() takes no args and returns name. SELECT quote_ident( name ) = quote_ident( name::text ) AS t FROM srt; t diff --git a/contrib/citext/expected/citext_1.out b/contrib/citext/expected/citext_1.out index 4a979d7a0d..c5e5f180f2 100644 --- a/contrib/citext/expected/citext_1.out +++ b/contrib/citext/expected/citext_1.out @@ -1744,15 +1744,6 @@ SELECT ltrim('zzzytrim'::citext, 'xyz'::text ) = 'trim' AS t; t (1 row) -SELECT md5( name ) = md5( name::text ) AS t FROM srt; - t ---- - t - t - t - t -(4 rows) - -- pg_client_encoding() takes no args and returns name. SELECT quote_ident( name ) = quote_ident( name::text ) AS t FROM srt; t diff --git a/contrib/citext/sql/citext.sql b/contrib/citext/sql/citext.sql index b329253d37..aa1cf9abd5 100644 --- a/contrib/citext/sql/citext.sql +++ b/contrib/citext/sql/citext.sql @@ -574,7 +574,6 @@ SELECT ltrim('zzzytrim'::citext, 'xyz'::citext) = 'trim' AS t; SELECT ltrim('zzzytrim'::text, 'xyz'::citext) = 'trim' AS t; SELECT ltrim('zzzytrim'::citext, 'xyz'::text ) = 'trim' AS t; -SELECT md5( name ) = md5( name::text ) AS t FROM srt; -- pg_client_encoding() takes no args and returns name. SELECT quote_ident( name ) = quote_ident( name::text ) AS t FROM srt; SELECT quote_literal( name ) = quote_literal( name::text ) AS t FROM srt;