From 3c702b3ed1519624d50e7a42283b8d481a579f77 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 11 Apr 2022 13:22:37 -0400 Subject: [PATCH] Explicitly ignore guaranteed-true result from pgstat_lock_entry(). With nowait passed as false, pgstat_lock_entry() must return true so there's no need to check its result. Coverity seems unconvinced of this, so whack it upside the head with a (void) cast. --- src/backend/utils/activity/pgstat_shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c index b270c504ea..68ff6f51fc 100644 --- a/src/backend/utils/activity/pgstat_shmem.c +++ b/src/backend/utils/activity/pgstat_shmem.c @@ -920,7 +920,7 @@ pgstat_reset_entry(PgStat_Kind kind, Oid dboid, Oid objoid, TimestampTz ts) if (!entry_ref || entry_ref->shared_entry->dropped) return; - pgstat_lock_entry(entry_ref, false); + (void) pgstat_lock_entry(entry_ref, false); shared_stat_reset_contents(kind, entry_ref->shared_stats, ts); pgstat_unlock_entry(entry_ref); }