rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix comment about cross-checking the varnullingrels 

The nullingrels match checks are not limited to debugging builds.
Oversight in commit 867be9c07.

Author: Richard Guo
Reviewed-by: Alvaro Herrera, Tom Lane, Robert Haas
Discussion: https://postgr.es/m/CAMbWs4_SDsdYD7DdQw7RXc3jv3axbg+RGZ7aSi9GaqX=F8hNVw@mail.gmail.com
This commit is contained in:
Richard Guo 2024-06-10 13:05:20 +09:00
parent e656657f2b
commit 3cb19f45a3
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/optimizer/plan/setrefs.c
View File

@ -2775,11 +2775,11 @@ build_tlist_index_other_vars(List *tlist, int ignore_rel)
* Also ensure that varnosyn is incremented by rtoffset. * Also ensure that varnosyn is incremented by rtoffset.
* If no match, return NULL. * If no match, return NULL.
* *
* In debugging builds, we cross-check the varnullingrels of the subplan * We cross-check the varnullingrels of the subplan output Var based on
* output Var based on nrm_match. Most call sites should pass NRM_EQUAL * nrm_match. Most call sites should pass NRM_EQUAL indicating we expect
* indicating we expect an exact match. However, there are places where * an exact match. However, there are places where we haven't cleaned
* we haven't cleaned things up completely, and we have to settle for * things up completely, and we have to settle for allowing subset or
* allowing subset or superset matches. * superset matches.
*/ */
static Var * static Var *
search_indexed_tlist_for_var(Var *var, indexed_tlist *itlist, search_indexed_tlist_for_var(Var *var, indexed_tlist *itlist,