From 3d067c53b26dfeb95da0d75a65614b4d7b45c317 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Tue, 29 Mar 2022 13:48:39 -0400 Subject: [PATCH] In 020_createdb.pl, change order of command-line arguments. Linux thinks that something like "createdb foo -S bar" is perfectly fine, but Windows wants the options to precede any bare arguments, so we must write "createdb -S bar foo" for portability. Per reports from CI, the buildfarm, and Andres. Discussion: http://postgr.es/m/20220329173536.7d2ywdatsprxl4x6@alap3.anarazel.de --- src/bin/scripts/t/020_createdb.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/scripts/t/020_createdb.pl b/src/bin/scripts/t/020_createdb.pl index 14d3a9563d..b81f06a251 100644 --- a/src/bin/scripts/t/020_createdb.pl +++ b/src/bin/scripts/t/020_createdb.pl @@ -115,12 +115,12 @@ $node->command_checks_all( # Check database creation strategy $node->issues_sql_like( - [ 'createdb', '-T', 'foobar2', 'foobar6', '-S', 'wal_log'], + [ 'createdb', '-T', 'foobar2', '-S', 'wal_log', 'foobar6' ], qr/statement: CREATE DATABASE foobar6 STRATEGY wal_log TEMPLATE foobar2/, 'create database with WAL_LOG strategy'); $node->issues_sql_like( - [ 'createdb', '-T', 'foobar2', 'foobar7', '-S', 'file_copy'], + [ 'createdb', '-T', 'foobar2', '-S', 'file_copy', 'foobar7' ], qr/statement: CREATE DATABASE foobar7 STRATEGY file_copy TEMPLATE foobar2/, 'create database with FILE_COPY strategy');