mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-04 06:56:51 +02:00
Don't allow to set replication slot_name as ''.
We don't allow to create replication slot_name as an empty string ('') via SQL API pg_create_logical_replication_slot() but it is allowed to be set via Alter Subscription command. This will lead to apply worker repeatedly keep trying to stream data via slot_name '' and the user is not allowed to create the slot with that name. Author: Japin Li Reviewed-By: Ranier Vilela, Amit Kapila Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
This commit is contained in:
parent
6d0dc1a7da
commit
40295d158f
@ -159,6 +159,8 @@ parse_subscription_options(List *options,
|
|||||||
/* Setting slot_name = NONE is treated as no slot name. */
|
/* Setting slot_name = NONE is treated as no slot name. */
|
||||||
if (strcmp(*slot_name, "none") == 0)
|
if (strcmp(*slot_name, "none") == 0)
|
||||||
*slot_name = NULL;
|
*slot_name = NULL;
|
||||||
|
else
|
||||||
|
ReplicationSlotValidateName(*slot_name, ERROR);
|
||||||
}
|
}
|
||||||
else if (strcmp(defel->defname, "copy_data") == 0 && copy_data)
|
else if (strcmp(defel->defname, "copy_data") == 0 && copy_data)
|
||||||
{
|
{
|
||||||
|
@ -86,6 +86,9 @@ ALTER SUBSCRIPTION regress_testsub SET PUBLICATION testpub2, testpub3 WITH (refr
|
|||||||
ALTER SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist2';
|
ALTER SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist2';
|
||||||
ALTER SUBSCRIPTION regress_testsub SET (slot_name = 'newname');
|
ALTER SUBSCRIPTION regress_testsub SET (slot_name = 'newname');
|
||||||
-- fail
|
-- fail
|
||||||
|
ALTER SUBSCRIPTION regress_testsub SET (slot_name = '');
|
||||||
|
ERROR: replication slot name "" is too short
|
||||||
|
-- fail
|
||||||
ALTER SUBSCRIPTION regress_doesnotexist CONNECTION 'dbname=regress_doesnotexist2';
|
ALTER SUBSCRIPTION regress_doesnotexist CONNECTION 'dbname=regress_doesnotexist2';
|
||||||
ERROR: subscription "regress_doesnotexist" does not exist
|
ERROR: subscription "regress_doesnotexist" does not exist
|
||||||
ALTER SUBSCRIPTION regress_testsub SET (create_slot = false);
|
ALTER SUBSCRIPTION regress_testsub SET (create_slot = false);
|
||||||
|
@ -65,6 +65,9 @@ ALTER SUBSCRIPTION regress_testsub SET PUBLICATION testpub2, testpub3 WITH (refr
|
|||||||
ALTER SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist2';
|
ALTER SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist2';
|
||||||
ALTER SUBSCRIPTION regress_testsub SET (slot_name = 'newname');
|
ALTER SUBSCRIPTION regress_testsub SET (slot_name = 'newname');
|
||||||
|
|
||||||
|
-- fail
|
||||||
|
ALTER SUBSCRIPTION regress_testsub SET (slot_name = '');
|
||||||
|
|
||||||
-- fail
|
-- fail
|
||||||
ALTER SUBSCRIPTION regress_doesnotexist CONNECTION 'dbname=regress_doesnotexist2';
|
ALTER SUBSCRIPTION regress_doesnotexist CONNECTION 'dbname=regress_doesnotexist2';
|
||||||
ALTER SUBSCRIPTION regress_testsub SET (create_slot = false);
|
ALTER SUBSCRIPTION regress_testsub SET (create_slot = false);
|
||||||
|
Loading…
Reference in New Issue
Block a user