From 44ab2dac12a752022eb4fe3dba7beddbc3433a0e Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 20 Jan 2022 16:55:08 +0900 Subject: [PATCH] doc: Mention the level of locks taken on objects in COMMENT This information was nowhere to be found. This adds one note on the page of COMMENT, and one note in the section dedicated to explicit locking, both telling that a SHARE UPDATE EXCLUSIVE lock is taken on the object commented. Author: Nikolai Berkoff Reviewed-by: Laurenz Albe Discussion: https://postgr.es/m/_0HDHIGcCdCsUyXn22QwI2FEuNR6Fs71rtgGX6hfyBlUh5rrnE2qMmvIFu9EY4Pijr2gUmJEAXCjuNU2Oxku9TryLp9CdHllpsCfN3gD0-Y=@pm.me Backpatch-through: 10 --- doc/src/sgml/mvcc.sgml | 2 +- doc/src/sgml/ref/comment.sgml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/src/sgml/mvcc.sgml b/doc/src/sgml/mvcc.sgml index 7e20a8a796..40159b8dcd 100644 --- a/doc/src/sgml/mvcc.sgml +++ b/doc/src/sgml/mvcc.sgml @@ -950,7 +950,7 @@ ERROR: could not serialize access due to read/write dependencies among transact Acquired by VACUUM (without ), ANALYZE, CREATE INDEX CONCURRENTLY, - CREATE STATISTICS and + CREATE STATISTICS, COMMENT ON and ALTER TABLE VALIDATE and other ALTER TABLE variants (for full details see ). diff --git a/doc/src/sgml/ref/comment.sgml b/doc/src/sgml/ref/comment.sgml index fd7492a255..138cf718ce 100644 --- a/doc/src/sgml/ref/comment.sgml +++ b/doc/src/sgml/ref/comment.sgml @@ -90,6 +90,11 @@ COMMENT ON Comments are automatically dropped when their object is dropped. + + A SHARE UPDATE EXCLUSIVE lock is acquired on the + object to be commented. + + For most kinds of object, only the object's owner can set the comment. Roles don't have owners, so the rule for COMMENT ON ROLE is