From 44bd3ed332d6ad3207f38b3b6deb6083f0baddf5 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Fri, 26 Nov 2021 11:14:27 -0300 Subject: [PATCH] Fix determination of broken LSN in OVERWRITTEN_CONTRECORD In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of the first record in a page, when the previous record ends exactly at the page boundary. The correct LSN is adjusted to skip the WAL page header; I failed to use that when setting XLogReaderState->overwrittenRecPtr, so at WAL replay time VerifyOverwriteContrecord would refuse to let replay continue past that record. Backpatch to 10. 9.6 also contains this bug, but it's no longer being maintained. Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us --- src/backend/access/transam/xlogreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c index f39f8044a9..3a7de02565 100644 --- a/src/backend/access/transam/xlogreader.c +++ b/src/backend/access/transam/xlogreader.c @@ -467,7 +467,7 @@ restart: */ if (pageHeader->xlp_info & XLP_FIRST_IS_OVERWRITE_CONTRECORD) { - state->overwrittenRecPtr = state->currRecPtr; + state->overwrittenRecPtr = RecPtr; ResetDecoder(state); RecPtr = targetPagePtr; goto restart;