mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-28 15:17:28 +02:00
Fix possible sorting error when aborting use of abbreviated keys.
Due to an error in the abbreviated key abort logic, the most recently processed SortTuple could be incorrectly marked NULL, resulting in an incorrect final sort order. In the worst case, this could result in a corrupt btree index, which would need to be rebuild using REINDEX. However, abbrevation doesn't abort very often, not all data types use it, and only one tuple would end up in the wrong place, so the practical impact of this mistake may be somewhat limited. Report and patch by Peter Geoghegan.
This commit is contained in:
parent
c3813268a7
commit
48b9ca0b60
@ -1443,7 +1443,7 @@ tuplesort_putindextuplevalues(Tuplesortstate *state, Relation rel,
|
||||
mtup->datum1 = index_getattr(tuple,
|
||||
1,
|
||||
RelationGetDescr(state->indexRel),
|
||||
&stup.isnull1);
|
||||
&mtup->isnull1);
|
||||
}
|
||||
}
|
||||
|
||||
@ -4271,7 +4271,7 @@ copytup_cluster(Tuplesortstate *state, SortTuple *stup, void *tup)
|
||||
mtup->datum1 = heap_getattr(tuple,
|
||||
state->indexInfo->ii_KeyAttrNumbers[0],
|
||||
state->tupDesc,
|
||||
&stup->isnull1);
|
||||
&mtup->isnull1);
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -4588,7 +4588,7 @@ copytup_index(Tuplesortstate *state, SortTuple *stup, void *tup)
|
||||
mtup->datum1 = index_getattr(tuple,
|
||||
1,
|
||||
RelationGetDescr(state->indexRel),
|
||||
&stup->isnull1);
|
||||
&mtup->isnull1);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user