rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-09-30 09:51:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Attached are patches for two fixes to reduce memory usage by the JDBC

Browse Source 
drivers.

The first fix fixes the PreparedStatement object to not allocate
unnecessary objects when converting native types to Stings.  The old
code used the following format:
        (new Integer(x)).toString()
whereas this can more efficiently be occompilshed by:
        Integer.toString(x);
avoiding the unnecessary object creation.

The second fix is to release some resources on the close() of a
ResultSet.  Currently the close() method on ResultSet is a noop.  The
purpose of the close() method is to release resources when the ResultSet
is no longer needed.  The fix is to free the tuples cached by the
ResultSet when it is closed (by clearing out the Vector object that
stores the tuples).  This is important for my application, as I have a
cache of Statement objects that I reuse.  Since the Statement object
maintains a reference to the ResultSet and the ResultSet kept references
to the old tuples, my cache was holding on to a lot of memory.

Barry Lind
This commit is contained in:
Bruce Momjian 2000-12-28 23:56:46 +00:00
parent a057cbec46
commit 49740c5fb9
4 changed files with 16 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/interfaces/jdbc/org/postgresql/jdbc1/PreparedStatement.java
View File

@ -164,7 +164,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setByte(int parameterIndex, byte x) throws SQLException
{
set(parameterIndex, (new Integer(x)).toString());
set(parameterIndex, Integer.toString(x));
}
/**
@ -177,7 +177,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setShort(int parameterIndex, short x) throws SQLException
{
set(parameterIndex, (new Integer(x)).toString());
set(parameterIndex, Integer.toString(x));
}
/**
@ -190,7 +190,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setInt(int parameterIndex, int x) throws SQLException
{
set(parameterIndex, (new Integer(x)).toString());
set(parameterIndex, Integer.toString(x));
}
/**
@ -203,7 +203,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setLong(int parameterIndex, long x) throws SQLException
{
set(parameterIndex, (new Long(x)).toString());
set(parameterIndex, Long.toString(x));
}
/**
@ -216,7 +216,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setFloat(int parameterIndex, float x) throws SQLException
{
set(parameterIndex, (new Float(x)).toString());
set(parameterIndex, Float.toString(x));
}
/**
@ -229,7 +229,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setDouble(int parameterIndex, double x) throws SQLException
{
set(parameterIndex, (new Double(x)).toString());
set(parameterIndex, Double.toString(x));
}
/**

3
src/interfaces/jdbc/org/postgresql/jdbc1/ResultSet.java
View File

@ -127,7 +127,8 @@ public class ResultSet extends org.postgresql.ResultSet implements java.sql.Resu
*/
public void close() throws SQLException
{
// No-op
//release resources held (memory for tuples)
rows.setSize(0);
}
/**

12
src/interfaces/jdbc/org/postgresql/jdbc2/PreparedStatement.java
View File

@ -164,7 +164,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setByte(int parameterIndex, byte x) throws SQLException
{
set(parameterIndex, (new Integer(x)).toString());
set(parameterIndex, Integer.toString(x));
}
/**
@ -177,7 +177,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setShort(int parameterIndex, short x) throws SQLException
{
set(parameterIndex, (new Integer(x)).toString());
set(parameterIndex, Integer.toString(x));
}
/**
@ -190,7 +190,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setInt(int parameterIndex, int x) throws SQLException
{
set(parameterIndex, (new Integer(x)).toString());
set(parameterIndex, Integer.toString(x));
}
/**
@ -203,7 +203,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setLong(int parameterIndex, long x) throws SQLException
{
set(parameterIndex, (new Long(x)).toString());
set(parameterIndex, Long.toString(x));
}
/**
@ -216,7 +216,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setFloat(int parameterIndex, float x) throws SQLException
{
set(parameterIndex, (new Float(x)).toString());
set(parameterIndex, Float.toString(x));
}
/**
@ -229,7 +229,7 @@ public class PreparedStatement extends Statement implements java.sql.PreparedSta
*/
public void setDouble(int parameterIndex, double x) throws SQLException
{
set(parameterIndex, (new Double(x)).toString());
set(parameterIndex, Double.toString(x));
}
/**

3
src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java
View File

@ -128,7 +128,8 @@ public class ResultSet extends org.postgresql.ResultSet implements java.sql.Resu
*/
public void close() throws SQLException
{
// No-op
//release resources held (memory for tuples)
rows.setSize(0);
}
/**