rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use ExplainPropertyInteger for queryid in EXPLAIN 

This saves a few lines of code.  Also add a comment to mention why we use
ExplainPropertyInteger instead of ExplainPropertyUInteger given that
queryid is a uint64 type.

Author: David Rowley
Reviewed-by: Julien Rouhaud
Discussion: https://postgr.es/m/CAApHDvqhSLYpSU_EqUdN39w9Uvb8ogmHV7_3YhJ0S3aScGBjsg@mail.gmail.com
Backpatch-through: 14, where this code was originally added
This commit is contained in:
David Rowley 2021-08-09 15:47:00 +12:00
parent c9229d3d2b
commit 4a3d806f38
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/commands/explain.c
View File

@ -606,10 +606,12 @@ ExplainOnePlan(PlannedStmt *plannedstmt, IntoClause *into, ExplainState *es,
if (es->verbose && plannedstmt->queryId != UINT64CONST(0)) if (es->verbose && plannedstmt->queryId != UINT64CONST(0))
{ {
char buf[MAXINT8LEN + 1]; /*
* Output the queryid as an int64 rather than a uint64 so we match
pg_lltoa(plannedstmt->queryId, buf); * what would be seen in the BIGINT pg_stat_statements.queryid column.
ExplainPropertyText("Query Identifier", buf, es); */
ExplainPropertyInteger("Query Identifier", NULL, (int64)
plannedstmt->queryId, es);
} }
/* Show buffer usage in planning */ /* Show buffer usage in planning */