Remove unnecessary PGDATABASE settings from TAP tests
Some of the TAP tests have been historically setting the environment
variable PGDATABASE to 'postgres', which is not needed because
PostgreSQL::Test::Cluster already sets it when initialized. This commit
removes these explicit setups.
Note that the dependency of cluster -a with PGDATABASE (from
1caef31d9e
) is still documented.
Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACXLAz5dW3ZP+Fec8g6jQMMmDyCVT+qdbye2h7QJJmhsdw@mail.gmail.com
This commit is contained in:
parent
ae6bc39317
commit
4b66d7b4e0
|
@ -12,10 +12,8 @@ my $node = PostgreSQL::Test::Cluster->new('main');
|
|||
$node->init;
|
||||
$node->start;
|
||||
|
||||
# clusterdb -a is not compatible with -d, hence enforce environment variable
|
||||
# correctly.
|
||||
$ENV{PGDATABASE} = 'postgres';
|
||||
|
||||
# clusterdb -a is not compatible with -d. This relies on PGDATABASE to be
|
||||
# set, something PostgreSQL::Test::Cluster does.
|
||||
$node->issues_sql_like(
|
||||
[ 'clusterdb', '-a' ],
|
||||
qr/statement: CLUSTER.*statement: CLUSTER/s,
|
||||
|
|
|
@ -8,8 +8,6 @@ use PostgreSQL::Test::Cluster;
|
|||
use PostgreSQL::Test::Utils;
|
||||
use Test::More;
|
||||
|
||||
$ENV{PGDATABASE} = 'postgres';
|
||||
|
||||
# Ensure that a cascading standby is able to follow a newly-promoted standby
|
||||
# on a new timeline.
|
||||
|
||||
|
|
|
@ -12,8 +12,6 @@ use PostgreSQL::Test::Cluster;
|
|||
use Test::More;
|
||||
use Time::HiRes qw(usleep);
|
||||
|
||||
$ENV{PGDATABASE} = 'postgres';
|
||||
|
||||
# Initialize primary node, setting wal-segsize to 1MB
|
||||
my $node_primary = PostgreSQL::Test::Cluster->new('primary');
|
||||
$node_primary->init(allows_streaming => 1, extra => ['--wal-segsize=1']);
|
||||
|
|
Loading…
Reference in New Issue