From 4b763ff642e1a3608cbcaff062f6c2f465bfc6bd Mon Sep 17 00:00:00 2001 From: David Rowley Date: Wed, 28 Jul 2021 12:56:43 +1200 Subject: [PATCH] Remove seemingly unneeded include directory in MSVC scripts This appears to have been added way back in ee3b4188a but it's a little unclear why the change made in that commit is even needed given that 320c7eb8c, dated 18 months earlier, added code to copy fmgroids.h to src/include/utils. amcheck seems to get away without adding the additional include directory, so perhaps dblink can get away with it too. This builds ok in my VS2017 environment, but the buildfarm may serve as a reminder about why ee3b4188a was required. There's only one way to find out for sure. Discussion: https://postgr.es/m/CAApHDvpo6g5csCTjc_0C7DMvgFPomVb0Rh-AcW5afd=Ya=LRuw@mail.gmail.com --- src/tools/msvc/Mkvcbuild.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm index 233ddbf4c2..4c36e482fb 100644 --- a/src/tools/msvc/Mkvcbuild.pm +++ b/src/tools/msvc/Mkvcbuild.pm @@ -41,7 +41,7 @@ my @contrib_uselibpq = my @contrib_uselibpgport = ('libpq_pipeline', 'oid2name', 'vacuumlo'); my @contrib_uselibpgcommon = ('libpq_pipeline', 'oid2name', 'vacuumlo'); my $contrib_extralibs = { 'libpq_pipeline' => ['ws2_32.lib'] }; -my $contrib_extraincludes = { 'dblink' => ['src/backend'] }; +my $contrib_extraincludes = {}; my $contrib_extrasource = { 'cube' => [ 'contrib/cube/cubescan.l', 'contrib/cube/cubeparse.y' ], 'seg' => [ 'contrib/seg/segscan.l', 'contrib/seg/segparse.y' ],