Revert addition of "o" to tar options. This was intended to fix bug #4883,

but the cure appears to be worse than the disease.  It turns out that GNU
tar versions 1.14.x misinterpret -o as --same-owner, not --no-same-owner,
leading to exactly the wrong behavior for both root and nonroot users.
While that bug has been fixed for nearly five years, these tar versions
are still found in the wild, notably in OS X 10.4.  Given that #4883 was
the first complaint we'd heard, it's definitely not worth fixing at the
risk of breaking things for other users.  Perhaps revisit at a later date
when we're not up against a release deadline.
This commit is contained in:
Tom Lane 2009-06-27 21:06:46 +00:00
parent 41f467f343
commit 4d53a2f969
1 changed files with 3 additions and 3 deletions

View File

@ -4,7 +4,7 @@
#
# Copyright (c) 1994, Regents of the University of California
#
# $PostgreSQL: pgsql/doc/Makefile,v 1.36 2009/06/26 06:40:57 petere Exp $
# $PostgreSQL: pgsql/doc/Makefile,v 1.37 2009/06/27 21:06:46 tgl Exp $
#
#----------------------------------------------------------------------------
@ -53,7 +53,7 @@ man1/.timestamp: man7/.timestamp
@echo timestamp >$@
man7/.timestamp: man.tar.gz
gzip -d -c $< | $(TAR) xof -
gzip -d -c $< | $(TAR) xf -
ifneq ($(sqlmansectnum),7)
for file in man1/*.1; do \
mv $$file $$file.bak && \
@ -76,7 +76,7 @@ endif # found_man
install: all installdirs
ifdef found_html
gzip -d -c $(srcdir)/postgres.tar.gz | ( cd $(DESTDIR)$(htmldir)/html && $(TAR) xof - )
gzip -d -c $(srcdir)/postgres.tar.gz | ( cd $(DESTDIR)$(htmldir)/html && $(TAR) xf - )
endif
ifdef found_man
for file in man1/*.1 man$(sqlmansectnum)/*.$(sqlmansect) ; do \