From 4d916dd876c3d9a4ceff5a0c54c5c58a0d1052e3 Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Tue, 16 Apr 2024 17:31:03 +0200 Subject: [PATCH] Stabilize test of BRIN parallel create The test for parallel create of BRIN indexes added by commit 8225c2fd40 happens to be unstable - a background transaction (e.g. auto-analyze) may hold back global xmin for the initial VACUUM / CREATE INDEX. If the cleanup happens before the next CREATE INDEX, the indexes will not be exactly the same. This is the same issue as e2933a6e11, so fix it the same way by making the table TEMPORARY, which uses an up-to-date cutoff xmin that is not held back by other processes. Reported by Alexander Lakhin, who also suggested the fix. Author: Alexander Lakhin Discussion: https://postgr.es/m/b58901cd-a7cc-29c6-e2b1-e3d7317c3c69@gmail.com Discussion: https://postgr.es/m/2892135.1668976646@sss.pgh.pa.us --- contrib/pageinspect/expected/brin.out | 2 +- contrib/pageinspect/sql/brin.sql | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/pageinspect/expected/brin.out b/contrib/pageinspect/expected/brin.out index 67c3549a12..e59451af4b 100644 --- a/contrib/pageinspect/expected/brin.out +++ b/contrib/pageinspect/expected/brin.out @@ -109,7 +109,7 @@ SELECT (COUNT(*) = (SELECT relpages FROM pg_class WHERE relname = 'test2')) AS r DROP TABLE test1; DROP TABLE test2; -- Test that parallel index build produces the same BRIN index as serial build. -CREATE TABLE brin_parallel_test (a int, b text, c bigint) WITH (fillfactor=40); +CREATE TEMPORARY TABLE brin_parallel_test (a int, b text, c bigint) WITH (fillfactor=40); -- Generate a table with a mix of NULLs and non-NULL values (and data suitable -- for the different opclasses we build later). INSERT INTO brin_parallel_test diff --git a/contrib/pageinspect/sql/brin.sql b/contrib/pageinspect/sql/brin.sql index a25969d58f..ac375a427d 100644 --- a/contrib/pageinspect/sql/brin.sql +++ b/contrib/pageinspect/sql/brin.sql @@ -56,7 +56,7 @@ DROP TABLE test1; DROP TABLE test2; -- Test that parallel index build produces the same BRIN index as serial build. -CREATE TABLE brin_parallel_test (a int, b text, c bigint) WITH (fillfactor=40); +CREATE TEMPORARY TABLE brin_parallel_test (a int, b text, c bigint) WITH (fillfactor=40); -- Generate a table with a mix of NULLs and non-NULL values (and data suitable -- for the different opclasses we build later).