rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-09-28 06:41:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

In transam.h, don't expose static inline functions to frontend code.

Browse Source 
That leads to unsatisfied external references if the C compiler fails
to elide unused static functions.  Apparently, we have no buildfarm
members building HEAD that have that issue ... but such compilers still
exist in the wild.  Need to do something about that.

In passing, fix Berkeley-era typo in comment.

Discussion: https://postgr.es/m/27054.1558533367@sss.pgh.pa.us
This commit is contained in:
Tom Lane 2019-05-22 10:38:21 -04:00
parent b8c6014a65
commit 4fbf809e13
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/include/access/transam.h
View File

@ -231,6 +231,13 @@ extern void AdvanceOldestClogXid(TransactionId oldest_datfrozenxid);
extern bool ForceTransactionIdLimitUpdate(void);
extern Oid GetNewObjectId(void);
/*
* Some frontend programs include this header. For compilers that emit static
* inline functions even when they're unused, that leads to unsatisfied
* external references; hence hide them with #ifndef FRONTEND.
*/
#ifndef FRONTEND
/*
* For callers that just need the XID part of the next transaction ID.
*/
@ -240,4 +247,6 @@ ReadNewTransactionId(void)
return XidFromFullTransactionId(ReadNextFullTransactionId());
}
#endif /* TRAMSAM_H */
#endif /* FRONTEND */
#endif /* TRANSAM_H */