From 57ae7885cfe7a6301e1fd4b59c2e525ecc35cd55 Mon Sep 17 00:00:00 2001 From: Peter Geoghegan Date: Wed, 10 Mar 2021 19:00:48 -0800 Subject: [PATCH] Drop index behind pg_upgrade test issue. The vacuum_cleanup_index_scale_factor storage parameter was set in a btree index that was previously left behind in the regression test database. As a result, the index gets tested within pg_dump and pg_restore tests, as well as pg_upgrade testing. This won't work when upgrading to Postgres 14, though, because the storage parameter was removed on that version by commit 9f3665fb. Fix the test failure by dropping the index in question. Per buildfarm member crake. Discussion: https://postgr.es/m/CAH2-WzmeXYBWdhF7BMhNjhq9exsk=E1ohqBFAwzPdXJZ1XDMUA@mail.gmail.com Backpatch: 11-12 only --- src/test/regress/expected/btree_index.out | 1 + src/test/regress/sql/btree_index.sql | 1 + 2 files changed, 2 insertions(+) diff --git a/src/test/regress/expected/btree_index.out b/src/test/regress/expected/btree_index.out index f567117a46..29c3f43957 100644 --- a/src/test/regress/expected/btree_index.out +++ b/src/test/regress/expected/btree_index.out @@ -312,6 +312,7 @@ select reloptions from pg_class WHERE oid = 'btree_idx1'::regclass; {vacuum_cleanup_index_scale_factor=70.0} (1 row) +drop index btree_idx1; -- -- Test for multilevel page deletion -- diff --git a/src/test/regress/sql/btree_index.sql b/src/test/regress/sql/btree_index.sql index 558dcae0ec..537c5025d4 100644 --- a/src/test/regress/sql/btree_index.sql +++ b/src/test/regress/sql/btree_index.sql @@ -140,6 +140,7 @@ create index btree_idx_err on btree_test(a) with (vacuum_cleanup_index_scale_fac -- Simple ALTER INDEX alter index btree_idx1 set (vacuum_cleanup_index_scale_factor = 70.0); select reloptions from pg_class WHERE oid = 'btree_idx1'::regclass; +drop index btree_idx1; -- -- Test for multilevel page deletion