rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove dead code from nbtsplitloc.c. 

It doesn't make sense to consider the possibility that there will only
be one candidate split point when choosing among split points to find
the split with the lowest penalty.  This is a vestige of an earlier
version of the patch that became commit fab25024.

Issue spotted while rereviewing coverage of the nbtree patch series
using gcov.
This commit is contained in:
Peter Geoghegan 2019-03-24 12:28:58 -07:00
parent bd9396a0b2
commit 59ab3be9e4
1 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/access/nbtree/nbtsplitloc.c
View File

@ -520,13 +520,12 @@ _bt_splitcmp(const void *arg1, const void *arg2)
}
/*
* Subroutine to find the "best" split point among an array of acceptable
* candidate split points that split without there being an excessively high
* delta between the space left free on the left and right halves. The "best"
* split point is the split point with the lowest penalty among split points
* that fall within current/final split interval. Penalty is an abstract
* score, with a definition that varies depending on whether we're splitting a
* leaf page or an internal page. See _bt_split_penalty() for details.
* Subroutine to find the "best" split point among candidate split points.
* The best split point is the split point with the lowest penalty among split
* points that fall within current/final split interval. Penalty is an
* abstract score, with a definition that varies depending on whether we're
* splitting a leaf page or an internal page. See _bt_split_penalty() for
* details.
*
* "perfectpenalty" is assumed to be the lowest possible penalty among
* candidate split points. This allows us to return early without wasting
@ -545,13 +544,6 @@ _bt_bestsplitloc(FindSplitData *state, int perfectpenalty, bool *newitemonleft)
lowsplit;
int highsplit = Min(state->interval, state->nsplits);
/* No point in calculating penalty when there's only one choice */
if (state->nsplits == 1)
{
*newitemonleft = state->splits[0].newitemonleft;
return state->splits[0].firstoldonright;
}
bestpenalty = INT_MAX;
lowsplit = 0;
for (int i = lowsplit; i < highsplit; i++)