From 5a5cb300967416846c06982fa34fff9ad4900e6b Mon Sep 17 00:00:00 2001
From: Bruce Momjian <bruce@momjian.us>
Date: Fri, 5 Dec 1997 01:13:24 +0000
Subject: [PATCH] Fix tolower loops to go in  proper direction for cache.

---
 src/backend/commands/define.c     | 4 ++--
 src/backend/commands/proclang.c   | 2 +-
 src/backend/parser/scan.l         | 4 ++--
 src/bin/psql/psql.c               | 6 +++---
 src/interfaces/libpq/fe-connect.c | 4 ++--
 src/interfaces/libpq/fe-exec.c    | 4 ++--
 6 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/backend/commands/define.c b/src/backend/commands/define.c
index 100f2fc7a5..5fabdcb92d 100644
--- a/src/backend/commands/define.c
+++ b/src/backend/commands/define.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/define.c,v 1.18 1997/11/26 04:50:28 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/define.c,v 1.19 1997/12/05 01:12:40 momjian Exp $
  *
  * DESCRIPTION
  *	  The "DefineFoo" routines take the parse tree and pick out the
@@ -69,7 +69,7 @@ case_translate_language_name(const char *input, char *output)
 --------------------------------------------------------------------------*/
 	int			i;
 
-	for (i = 0; i < NAMEDATALEN && input[i] != '\0'; ++i)
+	for (i = 0; i < NAMEDATALEN && input[i]; ++i)
 		output[i] = tolower(input[i]);
 
 	output[i] = '\0';
diff --git a/src/backend/commands/proclang.c b/src/backend/commands/proclang.c
index 8cc8b5ae48..caa1c8b832 100644
--- a/src/backend/commands/proclang.c
+++ b/src/backend/commands/proclang.c
@@ -28,7 +28,7 @@ case_translate_language_name(const char *input, char *output)
 --------------------------------------------------------------------------*/
 	int			i;
 
-	for (i = 0; i < NAMEDATALEN && input[i] != '\0'; ++i)
+	for (i = 0; i < NAMEDATALEN && input[i]; ++i)
 		output[i] = tolower(input[i]);
 
 	output[i] = '\0';
diff --git a/src/backend/parser/scan.l b/src/backend/parser/scan.l
index 1c5db68ad6..9e300ba111 100644
--- a/src/backend/parser/scan.l
+++ b/src/backend/parser/scan.l
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.31 1997/11/30 23:05:36 thomas Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.32 1997/12/05 01:12:53 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -355,7 +355,7 @@ other			.
 					int i;
 					ScanKeyword		*keyword;
 
-					for(i = strlen(yytext); i >= 0; i--)
+					for(i = 0; yytext[i]; i++)
 						if (isupper(yytext[i]))
 							yytext[i] = tolower(yytext[i]);
 
diff --git a/src/bin/psql/psql.c b/src/bin/psql/psql.c
index ed2b46e268..2232cf72e9 100644
--- a/src/bin/psql/psql.c
+++ b/src/bin/psql/psql.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/bin/psql/Attic/psql.c,v 1.118 1997/11/30 17:46:01 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/bin/psql/Attic/psql.c,v 1.119 1997/12/05 01:13:11 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -558,7 +558,7 @@ tableDesc(PsqlSettings *pset, char *table, FILE *fout)
 	}
 	else
 	{
-		for (i = strlen(table); i >= 0; i--)
+		for (i = 0; table[i]; i++)
 			if (isupper(table[i]))
 				table[i] = tolower(table[i]);
 	}
@@ -708,7 +708,7 @@ objectDescription(PsqlSettings *pset, char *object, FILE *fout)
 	}
 	else
 	{
-		for (i = strlen(object); i >= 0; i--)
+		for (i = 0; object[i]; i++)
 			if (isupper(object[i]))
 				object[i] = tolower(object[i]);
 	}
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index ad0b44f651..2dfaf95abe 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.52 1997/12/04 20:32:35 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.53 1997/12/05 01:13:21 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -444,7 +444,7 @@ PQsetdbLogin(const char *pghost, const char *pgport, const char *pgoptions, cons
 				*(conn->dbName + strlen(conn->dbName) - 1) = '\0';
 			}
 			else
-				for (i = strlen(conn->dbName); i >= 0; i--)
+				for (i = 0; conn->dbName[i]; i++)
 					if (isupper(conn->dbName[i]))
 						conn->dbName[i] = tolower(conn->dbName[i]);
 		}
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
index d9609ee328..69c93b7bd0 100644
--- a/src/interfaces/libpq/fe-exec.c
+++ b/src/interfaces/libpq/fe-exec.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.43 1997/12/04 23:28:20 thomas Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v 1.44 1997/12/05 01:13:24 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1697,7 +1697,7 @@ PQfnumber(PGresult *res, const char *field_name)
 		*(field_case + strlen(field_case) - 1) = '\0';
 	}
 	else
-		for (i = 0; i < strlen(field_case); i++)
+		for (i = 0; field_case[i]; i++)
 			if (isupper(field_case[i]))
 				field_case[i] = tolower(field_case[i]);