Don't uselessly escape a string that doesn't need escaping

Per gripe from Ian Barwick

Co-authored-by: Ian Barwick <ian@2ndquadrant.com>
Discussion: https://postgr.es/m/CABvVfJWNnNKb8cHsTLhkTsvL1+G6BVcV+57+w1JZ61p8YGPdWQ@mail.gmail.com
This commit is contained in:
Alvaro Herrera 2019-07-26 17:46:40 -04:00
parent d095b2fe67
commit 5ac684381d

View File

@ -1712,9 +1712,9 @@ GenerateRecoveryConf(PGconn *conn)
if (replication_slot) if (replication_slot)
{ {
escaped = escape_quotes(replication_slot); /* unescaped: ReplicationSlotValidateName allows [a-z0-9_] only */
appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", replication_slot); appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n",
free(escaped); replication_slot);
} }
if (PQExpBufferBroken(recoveryconfcontents) || if (PQExpBufferBroken(recoveryconfcontents) ||