Exclude snowball/libstemmer/ files from the set processed by pgindent.
There's not much point in prettifying machine-generated code, and it seems best to keep these files exactly like upstream anyway. Also add some notes about why various files are excluded.
This commit is contained in:
parent
1c36de33b0
commit
5c681ab1cb
|
@ -12,7 +12,7 @@ symbols.
|
||||||
From the top directory, run:
|
From the top directory, run:
|
||||||
|
|
||||||
find . -name '*.[ch]' -type f -print |
|
find . -name '*.[ch]' -type f -print |
|
||||||
egrep -v '/s_lock.h|src/interfaces/ecpg/test/expected/' |
|
egrep -v '/s_lock.h|/ecpg/test/expected/|/snowball/libstemmer/' |
|
||||||
xargs -n100 pgindent
|
xargs -n100 pgindent
|
||||||
|
|
||||||
We have standardized on NetBSD's indent. We have fixed a few bugs which
|
We have standardized on NetBSD's indent. We have fixed a few bugs which
|
||||||
|
@ -24,3 +24,15 @@ These bugs become pretty major when you are doing >500k lines of code.
|
||||||
If you don't believe me, take a directory and make a copy. Run pgindent
|
If you don't believe me, take a directory and make a copy. Run pgindent
|
||||||
on the copy using GNU indent, and do a diff -r. You will see what I
|
on the copy using GNU indent, and do a diff -r. You will see what I
|
||||||
mean. GNU indent does some things better, but mangles too.
|
mean. GNU indent does some things better, but mangles too.
|
||||||
|
|
||||||
|
Notes about excluded files:
|
||||||
|
|
||||||
|
src/include/storage/s_lock.h is excluded because it contains assembly code
|
||||||
|
that pgindent tends to mess up.
|
||||||
|
|
||||||
|
src/interfaces/ecpg/test/expected/ is excluded to avoid breaking the ecpg
|
||||||
|
regression tests.
|
||||||
|
|
||||||
|
src/include/snowball/libstemmer/ and src/backend/snowball/libstemmer/
|
||||||
|
are excluded because those files are imported from an external project,
|
||||||
|
not maintained locally, and are machine-generated anyway.
|
||||||
|
|
Loading…
Reference in New Issue