rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-08-28 09:47:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove overzeleous assertions in pg_atomic_flag code.

Browse Source 
The atomics code asserts proper alignment in various places. That's
mainly because the alignment of 64bit integers is not sufficient for
atomic operations on all platforms. Some ABIs only have four byte
alignment, but don't have atomic behavior when crossing page
boundaries.

The flags code isn't affected by that however, as the type alignment
always is sufficient for atomic operations. Nevertheless the code
asserted alignment requirements. Before 8c3debbb it was only broken on
hppa, after it probably affect further platforms.

Thus remove the assertions for pg_atomic_flag operators.

Per buildfarm animal pademelon.

Discussion: https://postgr.es/m/7223.1523124425@sss.pgh.pa.us
Backpatch: 9.5-
This commit is contained in:
Andres Freund 2018-04-07 18:27:14 -07:00
parent 1f3bbe00b7
commit 5faead30d8
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/include/port/atomics.h
View File

@ -173,8 +173,6 @@
static inline void
pg_atomic_init_flag(volatile pg_atomic_flag *ptr)
{
AssertPointerAlignment(ptr, sizeof(*ptr));
pg_atomic_init_flag_impl(ptr);
}
@ -188,8 +186,6 @@ pg_atomic_init_flag(volatile pg_atomic_flag *ptr)
static inline bool
pg_atomic_test_set_flag(volatile pg_atomic_flag *ptr)
{
AssertPointerAlignment(ptr, sizeof(*ptr));
return pg_atomic_test_set_flag_impl(ptr);
}
@ -203,8 +199,6 @@ pg_atomic_test_set_flag(volatile pg_atomic_flag *ptr)
static inline bool
pg_atomic_unlocked_test_flag(volatile pg_atomic_flag *ptr)
{
AssertPointerAlignment(ptr, sizeof(*ptr));
return pg_atomic_unlocked_test_flag_impl(ptr);
}
@ -216,8 +210,6 @@ pg_atomic_unlocked_test_flag(volatile pg_atomic_flag *ptr)
static inline void
pg_atomic_clear_flag(volatile pg_atomic_flag *ptr)
{
AssertPointerAlignment(ptr, sizeof(*ptr));
pg_atomic_clear_flag_impl(ptr);
}