rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename removable xid function for consistency. 

GlobalVisIsRemovableFullXid() is now GlobalVisCheckRemovableFullXid().
This is consistent with the general convention for FullTransactionId
equivalents of functions that deal with TransactionId values.  It now
matches the nearby GlobalVisCheckRemovableXid() function, which performs
the same check for callers that use TransactionId values.

Oversight in commit dc7420c2c9.

Discussion: https://postgr.es/m/CAH2-Wzmes12jFNDcVgpU89Vp=r6uLFrE-MT0fjSWGsE70UiNaA@mail.gmail.com
This commit is contained in:
Peter Geoghegan 2021-02-07 10:11:14 -08:00
parent d1d2979852
commit 617fffee8a
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/gist/gistutil.c
View File

@ -914,7 +914,7 @@ gistPageRecyclable(Page page)
*/
FullTransactionId deletexid_full = GistPageGetDeleteXid(page);
return GlobalVisIsRemovableFullXid(NULL, deletexid_full);
return GlobalVisCheckRemovableFullXid(NULL, deletexid_full);
}
return false;
}

2
src/backend/access/gist/gistxlog.c
View File

@ -388,7 +388,7 @@ gistRedoPageReuse(XLogReaderState *record)
* pages in the index via the FSM. That's all they do though.
*
* latestRemovedXid was the page's deleteXid. The
* GlobalVisIsRemovableFullXid(deleteXid) test in gistPageRecyclable()
* GlobalVisCheckRemovableFullXid(deleteXid) test in gistPageRecyclable()
* conceptually mirrors the PGPROC->xmin > limitXmin test in
* GetConflictingVirtualXIDs(). Consequently, one XID value achieves the
* same exclusion effect on primary and standby.

2
src/backend/storage/ipc/procarray.c
View File

@ -4146,7 +4146,7 @@ GlobalVisTestNonRemovableHorizon(GlobalVisState *state)
* GlobalVisTestIsRemovableFullXid(), see their comments.
*/
bool
GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid)
GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid)
{
GlobalVisState *state;

2
src/include/utils/snapmgr.h
View File

@ -155,7 +155,7 @@ extern bool GlobalVisTestIsRemovableFullXid(GlobalVisState *state, FullTransacti
extern FullTransactionId GlobalVisTestNonRemovableFullHorizon(GlobalVisState *state);
extern TransactionId GlobalVisTestNonRemovableHorizon(GlobalVisState *state);
extern bool GlobalVisCheckRemovableXid(Relation rel, TransactionId xid);
extern bool GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid);
extern bool GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid);
/*
* Utility functions for implementing visibility routines in table AMs.