Fix connection leak in dblink when dblink_connect() or dblink_connect_u()

end with "duplicate connection name" errors.

Backported to release 7.4.
This commit is contained in:
Itagaki Takahiro 2010-06-09 01:00:32 +00:00
parent 9d1f44113d
commit 63a601457d
1 changed files with 5 additions and 0 deletions

View File

@ -2124,9 +2124,14 @@ createNewConnection(const char *name, remoteConn * con)
errmsg("out of memory")));
if (found)
{
PQfinish(rconn->conn);
pfree(rconn);
ereport(ERROR,
(errcode(ERRCODE_DUPLICATE_OBJECT),
errmsg("duplicate connection name")));
}
hentry->rcon = con;
strncpy(hentry->name, name, NAMEDATALEN - 1);