rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

amcheck: Reduce debug message verbosity. 

Empty sibling pages can occasionally be much more common than any other
event that we report on at elevel DEBUG1.  Increase the elevel for
relevant cases to DEBUG2 to avoid overwhelming the user with relatively
insignificant details.
This commit is contained in:
Peter Geoghegan 2021-03-16 13:11:17 -07:00
parent 4b12ab18c9
commit 65445469d6
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
contrib/amcheck/verify_nbtree.c
View File

@ -721,7 +721,7 @@ bt_check_level_from_leftmost(BtreeCheckState *state, BtreeLevel level)
else else
ereport(DEBUG1, ereport(DEBUG1,
(errcode(ERRCODE_NO_DATA), (errcode(ERRCODE_NO_DATA),
errmsg_internal("block %u of index \"%s\" ignored", errmsg_internal("block %u of index \"%s\" concurrently deleted",
current, RelationGetRelationName(state->rel)))); current, RelationGetRelationName(state->rel))));
goto nextpage; goto nextpage;
} }
@ -1592,14 +1592,18 @@ bt_right_page_check_scankey(BtreeCheckState *state)
if (!P_IGNORE(opaque) || P_RIGHTMOST(opaque)) if (!P_IGNORE(opaque) || P_RIGHTMOST(opaque))
break; break;
/* We landed on a deleted page, so step right to find a live page */ /*
targetnext = opaque->btpo_next; * We landed on a deleted or half-dead sibling page. Step right until
ereport(DEBUG1, * we locate a live sibling page.
*/
ereport(DEBUG2,
(errcode(ERRCODE_NO_DATA), (errcode(ERRCODE_NO_DATA),
errmsg_internal("level %u leftmost page of index \"%s\" was found deleted or half dead", errmsg_internal("level %u sibling page in block %u of index \"%s\" was found deleted or half dead",
opaque->btpo_level, RelationGetRelationName(state->rel)), opaque->btpo_level, targetnext, RelationGetRelationName(state->rel)),
errdetail_internal("Deleted page found when building scankey from right sibling."))); errdetail_internal("Deleted page found when building scankey from right sibling.")));
targetnext = opaque->btpo_next;
/* Be slightly more pro-active in freeing this memory, just in case */ /* Be slightly more pro-active in freeing this memory, just in case */
pfree(rightpage); pfree(rightpage);
} }
@ -1722,7 +1726,7 @@ bt_right_page_check_scankey(BtreeCheckState *state)
* possible that it's an internal page with only a negative infinity * possible that it's an internal page with only a negative infinity
* item. * item.
*/ */
ereport(DEBUG1, ereport(DEBUG2,
(errcode(ERRCODE_NO_DATA), (errcode(ERRCODE_NO_DATA),
errmsg_internal("%s block %u of index \"%s\" has no first data item", errmsg_internal("%s block %u of index \"%s\" has no first data item",
P_ISLEAF(opaque) ? "leaf" : "internal", targetnext, P_ISLEAF(opaque) ? "leaf" : "internal", targetnext,