rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Further minor improvement in generic_xlog.c: always say REGBUF_STANDARD. 

Since we're requiring pages handled by generic_xlog.c to be standard
format, specify REGBUF_STANDARD when doing a full-page image, so that
xloginsert.c can compress out the "hole" between pd_lower and pd_upper.
Given the current API in which this path will be taken only for a newly
initialized page, the hole is likely to be particularly large in such
cases, so that this oversight could easily be performance-significant.
I don't notice any particular change in the runtime of contrib/bloom's
regression test, though.
This commit is contained in:
Tom Lane 2016-04-10 00:24:28 -04:00
parent 68689c66ef
commit 660d5fb856
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/access/transam/generic_xlog.c
View File

@ -349,7 +349,8 @@ GenericXLogFinish(GenericXLogState *state)
{
/* A full page image does not require anything special */
memcpy(page, pageData->image, BLCKSZ);
XLogRegisterBuffer(i, pageData->buffer, REGBUF_FORCE_IMAGE);
XLogRegisterBuffer(i, pageData->buffer,
REGBUF_FORCE_IMAGE | REGBUF_STANDARD);
}
else
{