From 66f0cf7da8eeaeca4b9894bfafd61789b514af4a Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sun, 26 Feb 2012 15:22:27 +0200 Subject: [PATCH] Remove useless const qualifier Claiming that the typevar argument to DefineCompositeType() is const was a plain lie. A similar case in DefineVirtualRelation() was already changed in passing in commit 1575fbcb. Also clean up the now unnecessary casts that used to cast away the const. --- src/backend/commands/typecmds.c | 4 ++-- src/backend/commands/view.c | 2 +- src/include/commands/typecmds.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c index 3523554cfb..22c1132e9b 100644 --- a/src/backend/commands/typecmds.c +++ b/src/backend/commands/typecmds.c @@ -1980,7 +1980,7 @@ AssignTypeArrayOid(void) *------------------------------------------------------------------- */ Oid -DefineCompositeType(const RangeVar *typevar, List *coldeflist) +DefineCompositeType(RangeVar *typevar, List *coldeflist) { CreateStmt *createStmt = makeNode(CreateStmt); Oid old_type_oid; @@ -1991,7 +1991,7 @@ DefineCompositeType(const RangeVar *typevar, List *coldeflist) * now set the parameters for keys/inheritance etc. All of these are * uninteresting for composite types... */ - createStmt->relation = (RangeVar *) typevar; + createStmt->relation = typevar; createStmt->tableElts = coldeflist; createStmt->inhRelations = NIL; createStmt->constraints = NIL; diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c index f895488a5a..99fb7dbb8f 100644 --- a/src/backend/commands/view.c +++ b/src/backend/commands/view.c @@ -254,7 +254,7 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace, * now set the parameters for keys/inheritance etc. All of these are * uninteresting for views... */ - createStmt->relation = (RangeVar *) relation; + createStmt->relation = relation; createStmt->tableElts = attrList; createStmt->inhRelations = NIL; createStmt->constraints = NIL; diff --git a/src/include/commands/typecmds.h b/src/include/commands/typecmds.h index 9de5330924..0c7e10d392 100644 --- a/src/include/commands/typecmds.h +++ b/src/include/commands/typecmds.h @@ -25,7 +25,7 @@ extern void DefineDomain(CreateDomainStmt *stmt); extern void DefineEnum(CreateEnumStmt *stmt); extern void DefineRange(CreateRangeStmt *stmt); extern void AlterEnum(AlterEnumStmt *stmt); -extern Oid DefineCompositeType(const RangeVar *typevar, List *coldeflist); +extern Oid DefineCompositeType(RangeVar *typevar, List *coldeflist); extern Oid AssignTypeArrayOid(void); extern void AlterDomainDefault(List *names, Node *defaultRaw);