rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-09-28 01:21:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

Respect Hot Standby controls while recycling btree index pages.

Browse Source 
Btree pages were recycled after VACUUM deletes all records on a
page and then a subsequent VACUUM occurs after the RecentXmin
horizon is reached. Using RecentXmin meant that we did not respond
correctly to the user controls provide to avoid Hot Standby
conflicts and so spurious conflicts could be generated in some
workload combinations. We now reuse pages only when we reach
RecentGlobalXmin, which can be much later in the presence of long
running queries and is also controlled by vacuum_defer_cleanup_age
and hot_standby_feedback.

Noah Misch and Simon Riggs
This commit is contained in:
Simon Riggs 2011-06-16 10:19:10 +01:00
parent 1568fa75bc
commit 758bd2a433
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/access/nbtree/nbtpage.c
View File

@ -677,6 +677,7 @@ bool
_bt_page_recyclable(Page page) _bt_page_recyclable(Page page)
{ {
BTPageOpaque opaque; BTPageOpaque opaque;
TransactionId cutoff;
/* /*
* It's possible to find an all-zeroes page in an index --- for example, a * It's possible to find an all-zeroes page in an index --- for example, a
@ -689,11 +690,18 @@ _bt_page_recyclable(Page page)
/* /*
* Otherwise, recycle if deleted and too old to have any processes * Otherwise, recycle if deleted and too old to have any processes
* interested in it. * interested in it. If we are generating records for Hot Standby
* defer page recycling until RecentGlobalXmin to respect user
* controls specified by vacuum_defer_cleanup_age or hot_standby_feedback.
*/ */
if (XLogStandbyInfoActive())
cutoff = RecentGlobalXmin;
else
cutoff = RecentXmin;
opaque = (BTPageOpaque) PageGetSpecialPointer(page); opaque = (BTPageOpaque) PageGetSpecialPointer(page);
if (P_ISDELETED(opaque) && if (P_ISDELETED(opaque) &&
TransactionIdPrecedesOrEquals(opaque->btpo.xact, RecentXmin)) TransactionIdPrecedesOrEquals(opaque->btpo.xact, cutoff))
return true; return true;
return false; return false;
} }