From 768ceeeaa127a8001d60ad6a62846a8be3f35d93 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 16 Apr 2024 09:38:46 +0900 Subject: [PATCH] Add missing PGDLLIMPORT markings All backend-side variables should be marked with PGDLLIMPORT, as per policy introduced in 8ec569479f. aafc05de1bf5 has forgotten MyClientSocket, and 05c3980e7f47 LoadedSSL. These can be spotted with a command like this one (be careful of not switching __pg_log_level): src/tools/mark_pgdllimport.pl $(git ls-files src/include/) Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/ZhzkRzrkKhbeQMRm@paquier.xyz --- src/include/postmaster/postmaster.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/postmaster/postmaster.h b/src/include/postmaster/postmaster.h index 8ce990e800..f6152eddf5 100644 --- a/src/include/postmaster/postmaster.h +++ b/src/include/postmaster/postmaster.h @@ -52,7 +52,7 @@ extern PGDLLIMPORT int postmaster_alive_fds[2]; extern PGDLLIMPORT const char *progname; -extern bool LoadedSSL; +extern PGDLLIMPORT bool LoadedSSL; extern void PostmasterMain(int argc, char *argv[]) pg_attribute_noreturn(); extern void ClosePostmasterPorts(bool am_syslogger); @@ -74,7 +74,7 @@ extern void pgwin32_register_deadchild_callback(HANDLE procHandle, DWORD procId) #endif /* defined in globals.c */ -extern struct ClientSocket *MyClientSocket; +extern PGDLLIMPORT struct ClientSocket *MyClientSocket; /* prototypes for functions in launch_backend.c */ extern pid_t postmaster_child_launch(BackendType child_type, char *startup_data, size_t startup_data_len, struct ClientSocket *sock);