mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-04 21:47:21 +02:00
Fix commit_ts for FrozenXid and BootstrapXid
Previously, requesting commit timestamp for transactions FrozenTransactionId and BootstrapTransactionId resulted in an error. But since those values can validly appear in committed tuples' Xmin, this behavior is unhelpful and error prone: each caller would have to special-case those values before requesting timestamp data for an Xid. We already have a perfectly good interface for returning "the Xid you requested is too old for us to have commit TS data for it", so let's use that instead. Backpatch to 9.5, where commit timestamps appeared. Author: Craig Ringer Discussion: https://www.postgresql.org/message-id/CAMsr+YFM5Q=+ry3mKvWEqRTxrB0iU3qUSRnS28nz6FJYtBwhJg@mail.gmail.com
This commit is contained in:
parent
e0375d77b6
commit
7816d13563
@ -288,11 +288,18 @@ TransactionIdGetCommitTsData(TransactionId xid, TimestampTz *ts,
|
|||||||
TransactionId oldestCommitTsXid;
|
TransactionId oldestCommitTsXid;
|
||||||
TransactionId newestCommitTsXid;
|
TransactionId newestCommitTsXid;
|
||||||
|
|
||||||
/* error if the given Xid doesn't normally commit */
|
if (!TransactionIdIsValid(xid))
|
||||||
if (!TransactionIdIsNormal(xid))
|
|
||||||
ereport(ERROR,
|
ereport(ERROR,
|
||||||
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
|
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
|
||||||
errmsg("cannot retrieve commit timestamp for transaction %u", xid)));
|
errmsg("cannot retrieve commit timestamp for transaction %u", xid)));
|
||||||
|
else if (!TransactionIdIsNormal(xid))
|
||||||
|
{
|
||||||
|
/* frozen and bootstrap xids are always committed far in the past */
|
||||||
|
*ts = 0;
|
||||||
|
if (nodeid)
|
||||||
|
*nodeid = 0;
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
LWLockAcquire(CommitTsLock, LW_SHARED);
|
LWLockAcquire(CommitTsLock, LW_SHARED);
|
||||||
|
|
||||||
|
@ -28,9 +28,17 @@ DROP TABLE committs_test;
|
|||||||
SELECT pg_xact_commit_timestamp('0'::xid);
|
SELECT pg_xact_commit_timestamp('0'::xid);
|
||||||
ERROR: cannot retrieve commit timestamp for transaction 0
|
ERROR: cannot retrieve commit timestamp for transaction 0
|
||||||
SELECT pg_xact_commit_timestamp('1'::xid);
|
SELECT pg_xact_commit_timestamp('1'::xid);
|
||||||
ERROR: cannot retrieve commit timestamp for transaction 1
|
pg_xact_commit_timestamp
|
||||||
|
--------------------------
|
||||||
|
|
||||||
|
(1 row)
|
||||||
|
|
||||||
SELECT pg_xact_commit_timestamp('2'::xid);
|
SELECT pg_xact_commit_timestamp('2'::xid);
|
||||||
ERROR: cannot retrieve commit timestamp for transaction 2
|
pg_xact_commit_timestamp
|
||||||
|
--------------------------
|
||||||
|
|
||||||
|
(1 row)
|
||||||
|
|
||||||
SELECT x.xid::text::bigint > 0, x.timestamp > '-infinity'::timestamptz, x.timestamp <= now() FROM pg_last_committed_xact() x;
|
SELECT x.xid::text::bigint > 0, x.timestamp > '-infinity'::timestamptz, x.timestamp <= now() FROM pg_last_committed_xact() x;
|
||||||
?column? | ?column? | ?column?
|
?column? | ?column? | ?column?
|
||||||
----------+----------+----------
|
----------+----------+----------
|
||||||
|
@ -23,9 +23,17 @@ DROP TABLE committs_test;
|
|||||||
SELECT pg_xact_commit_timestamp('0'::xid);
|
SELECT pg_xact_commit_timestamp('0'::xid);
|
||||||
ERROR: cannot retrieve commit timestamp for transaction 0
|
ERROR: cannot retrieve commit timestamp for transaction 0
|
||||||
SELECT pg_xact_commit_timestamp('1'::xid);
|
SELECT pg_xact_commit_timestamp('1'::xid);
|
||||||
ERROR: cannot retrieve commit timestamp for transaction 1
|
pg_xact_commit_timestamp
|
||||||
|
--------------------------
|
||||||
|
|
||||||
|
(1 row)
|
||||||
|
|
||||||
SELECT pg_xact_commit_timestamp('2'::xid);
|
SELECT pg_xact_commit_timestamp('2'::xid);
|
||||||
ERROR: cannot retrieve commit timestamp for transaction 2
|
pg_xact_commit_timestamp
|
||||||
|
--------------------------
|
||||||
|
|
||||||
|
(1 row)
|
||||||
|
|
||||||
SELECT x.xid::text::bigint > 0, x.timestamp > '-infinity'::timestamptz, x.timestamp <= now() FROM pg_last_committed_xact() x;
|
SELECT x.xid::text::bigint > 0, x.timestamp > '-infinity'::timestamptz, x.timestamp <= now() FROM pg_last_committed_xact() x;
|
||||||
ERROR: could not get commit timestamp data
|
ERROR: could not get commit timestamp data
|
||||||
HINT: Make sure the configuration parameter "track_commit_timestamp" is set.
|
HINT: Make sure the configuration parameter "track_commit_timestamp" is set.
|
||||||
|
Loading…
Reference in New Issue
Block a user