From 78b408a20a5a19486f0ed833466d0de342c7e471 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Sun, 3 Mar 2019 11:48:12 -0500 Subject: [PATCH] Avoid accidental wildcard expansion in msys shell Commit f092de05 added a test for pg_dumpall --exclude-database including the wildcard pattern '*dump*' which matches some files in the source directory. The test library on msys uses the shell which expands this and thus the program gets incorrect arguments. This doesn't happen if the pattern doesn't match any files, so here the pattern is set to '*dump_test*' which is such a pattern. Per buildfarm animal jacana. --- src/bin/pg_dump/t/002_pg_dump.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl index 8fa7f0f61f..668cb0f803 100644 --- a/src/bin/pg_dump/t/002_pg_dump.pl +++ b/src/bin/pg_dump/t/002_pg_dump.pl @@ -227,7 +227,7 @@ my %pgdump_runs = ( pg_dumpall_exclude => { dump_cmd => [ 'pg_dumpall', '-v', "--file=$tempdir/pg_dumpall_exclude.sql", - '--exclude-database', '*dump*', '--no-sync', + '--exclude-database', '*dump_test*', '--no-sync', ], }, no_blobs => {