Fix come incorrect elog() messages in aclchk.c
Three error strings used with cache lookup failures were referring to incorrect object types for ACL checks: - Schemas - Types - Foreign Servers There errors should never be triggered, but if they do incorrect information would be reported. Author: Justin Pryzby Discussion: https://postgr.es/m/20221222153041.GN1153@telsasoft.com Backpatch-through: 11
This commit is contained in:
parent
97431d6739
commit
7ad458e06b
|
@ -5752,7 +5752,7 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)
|
|||
|
||||
tuple = SearchSysCache1(FOREIGNSERVEROID, ObjectIdGetDatum(objoid));
|
||||
if (!HeapTupleIsValid(tuple))
|
||||
elog(ERROR, "cache lookup failed for foreign data wrapper %u",
|
||||
elog(ERROR, "cache lookup failed for foreign server %u",
|
||||
objoid);
|
||||
|
||||
aclDatum = SysCacheGetAttr(FOREIGNSERVEROID, tuple,
|
||||
|
@ -5838,7 +5838,7 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)
|
|||
|
||||
tuple = SearchSysCache1(NAMESPACEOID, ObjectIdGetDatum(objoid));
|
||||
if (!HeapTupleIsValid(tuple))
|
||||
elog(ERROR, "cache lookup failed for function %u", objoid);
|
||||
elog(ERROR, "cache lookup failed for schema %u", objoid);
|
||||
|
||||
aclDatum = SysCacheGetAttr(NAMESPACEOID, tuple,
|
||||
Anum_pg_namespace_nspacl, &isNull);
|
||||
|
@ -5880,7 +5880,7 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)
|
|||
|
||||
tuple = SearchSysCache1(TYPEOID, ObjectIdGetDatum(objoid));
|
||||
if (!HeapTupleIsValid(tuple))
|
||||
elog(ERROR, "cache lookup failed for function %u", objoid);
|
||||
elog(ERROR, "cache lookup failed for type %u", objoid);
|
||||
|
||||
aclDatum = SysCacheGetAttr(TYPEOID, tuple, Anum_pg_type_typacl,
|
||||
&isNull);
|
||||
|
|
Loading…
Reference in New Issue