rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-10-01 01:01:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

TestConfiguration returns int, not bool. This mistake is relatively

Browse Source 
harmless on signed-char machines but would lead to core dump in the
deadlock detection code if char is unsigned.  Amazingly, this bug has
been here since 7.1 and yet wasn't reported till now.  Thanks to Robert
Bruccoleri for providing the opportunity to track it down.
This commit is contained in:
Tom Lane 2003-03-31 20:32:29 +00:00
parent 80597fd992
commit 7cd30e1590
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/storage/lmgr/deadlock.c
View File

@ -12,7 +12,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/storage/lmgr/deadlock.c,v 1.19 2003/02/19 23:41:15 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/storage/lmgr/deadlock.c,v 1.20 2003/03/31 20:32:29 tgl Exp $
* *
* Interface: * Interface:
* *
@ -64,7 +64,7 @@ typedef struct
static bool DeadLockCheckRecurse(PGPROC *proc); static bool DeadLockCheckRecurse(PGPROC *proc);
static bool TestConfiguration(PGPROC *startProc); static int TestConfiguration(PGPROC *startProc);
static bool FindLockCycle(PGPROC *checkProc, static bool FindLockCycle(PGPROC *checkProc,
EDGE *softEdges, int *nSoftEdges); EDGE *softEdges, int *nSoftEdges);
static bool FindLockCycleRecurse(PGPROC *checkProc, int depth, static bool FindLockCycleRecurse(PGPROC *checkProc, int depth,
@ -338,7 +338,7 @@ DeadLockCheckRecurse(PGPROC *proc)
* number of soft edges. * number of soft edges.
*-------------------- *--------------------
*/ */
static bool static int
TestConfiguration(PGPROC *startProc) TestConfiguration(PGPROC *startProc)
{ {
int softFound = 0; int softFound = 0;