From 7ed9285c6950d6b006ce745e9fd5e950425e815c Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Wed, 20 Feb 2019 12:31:27 +0900 Subject: [PATCH] Mark correctly initial slot snapshots with MVCC type when built MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When building an initial slot snapshot, snapshots are marked with historic MVCC snapshots as type with the marker field being set in SnapBuildBuildSnapshot() but not overriden in SnapBuildInitialSnapshot(). Existing callers of SnapBuildBuildSnapshot() do not care about the type of snapshot used, but extensions calling it actually may, as reported. Author: Antonin Houska Reviewed-by: Álvaro Herrera, Michael Paquier Discussion: https://postgr.es/m/23215.1527665193@localhost Backpatch-through: 9.4 --- src/backend/replication/logical/snapbuild.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c index f17cbda8a0..9b81874ce1 100644 --- a/src/backend/replication/logical/snapbuild.c +++ b/src/backend/replication/logical/snapbuild.c @@ -617,6 +617,8 @@ SnapBuildInitialSnapshot(SnapBuild *builder) TransactionIdAdvance(xid); } + /* adjust remaining snapshot fields as needed */ + snap->satisfies = HeapTupleSatisfiesMVCC; snap->xcnt = newxcnt; snap->xip = newxip;