From 806091c96f9b81f7631e4e37a05af377b473b5da Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Thu, 9 Feb 2017 15:10:09 -0500 Subject: [PATCH] Remove all references to "xlog" from SQL-callable functions in pg_proc. Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog directory to pg_wal. To make things consistent, and because "xlog" is terrible terminology for either "transaction log" or "write-ahead log" rename all SQL-callable functions that contain "xlog" in the name to instead contain "wal". (Note that this may pose an upgrade hazard for some users.) Similarly, rename the xlog_position argument of the functions that create slots to be called wal_position. Discussion: https://www.postgresql.org/message-id/CA+Tgmob=YmA=H3DbW1YuOXnFVgBheRmyDkWcD9M8f=5bGWYEoQ@mail.gmail.com --- contrib/bloom/t/001_wal.pl | 2 +- contrib/test_decoding/expected/ddl.out | 2 +- contrib/test_decoding/sql/ddl.sql | 2 +- doc/src/sgml/backup.sgml | 2 +- doc/src/sgml/func.sgml | 72 +++++++++---------- doc/src/sgml/high-availability.sgml | 14 ++-- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/recovery-config.sgml | 2 +- .../access/transam/recovery.conf.sample | 2 +- src/backend/access/transam/xlog.c | 2 +- src/backend/access/transam/xlogfuncs.c | 36 +++++----- src/backend/catalog/system_views.sql | 10 +-- src/bin/pg_basebackup/t/030_pg_recvlogical.pl | 2 +- src/bin/pg_rewind/RewindTest.pm | 2 +- src/bin/pg_rewind/libpq_fetch.c | 4 +- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h | 52 +++++++------- src/test/modules/commit_ts/t/002_standby.pl | 8 +-- src/test/modules/commit_ts/t/003_standby_2.pl | 4 +- src/test/perl/PostgresNode.pm | 10 +-- src/test/recovery/t/002_archiving.pl | 6 +- src/test/recovery/t/003_recovery_targets.pl | 16 ++--- src/test/recovery/t/005_replay_delay.pl | 4 +- src/test/recovery/t/008_fsm_truncation.pl | 4 +- .../regress/expected/hs_standby_functions.out | 2 +- src/test/regress/sql/hs_primary_extremes.sql | 2 +- src/test/regress/sql/hs_primary_setup.sql | 2 +- src/test/regress/sql/hs_standby_functions.sql | 2 +- src/test/subscription/t/001_rep_changes.pl | 2 +- src/test/subscription/t/002_types.pl | 2 +- 30 files changed, 137 insertions(+), 137 deletions(-) diff --git a/contrib/bloom/t/001_wal.pl b/contrib/bloom/t/001_wal.pl index 56c6618d3d..dc907baf87 100644 --- a/contrib/bloom/t/001_wal.pl +++ b/contrib/bloom/t/001_wal.pl @@ -16,7 +16,7 @@ sub test_index_replay # Wait for standby to catch up my $applname = $node_standby->name; my $caughtup_query = -"SELECT pg_current_xlog_location() <= write_location FROM pg_stat_replication WHERE application_name = '$applname';"; +"SELECT pg_current_wal_location() <= write_location FROM pg_stat_replication WHERE application_name = '$applname';"; $node_master->poll_query_until('postgres', $caughtup_query) or die "Timed out while waiting for standby 1 to catch up"; diff --git a/contrib/test_decoding/expected/ddl.out b/contrib/test_decoding/expected/ddl.out index c104c4802d..275c84a450 100644 --- a/contrib/test_decoding/expected/ddl.out +++ b/contrib/test_decoding/expected/ddl.out @@ -58,7 +58,7 @@ SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_d SELECT slot_name, plugin, slot_type, active, NOT catalog_xmin IS NULL AS catalog_xmin_set, xmin IS NULl AS data_xmin_not_set, - pg_xlog_location_diff(restart_lsn, '0/01000000') > 0 AS some_wal + pg_wal_location_diff(restart_lsn, '0/01000000') > 0 AS some_wal FROM pg_replication_slots; slot_name | plugin | slot_type | active | catalog_xmin_set | data_xmin_not_set | some_wal -----------------+---------------+-----------+--------+------------------+-------------------+---------- diff --git a/contrib/test_decoding/sql/ddl.sql b/contrib/test_decoding/sql/ddl.sql index 89b8b8f780..49dad39b50 100644 --- a/contrib/test_decoding/sql/ddl.sql +++ b/contrib/test_decoding/sql/ddl.sql @@ -29,7 +29,7 @@ SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_d SELECT slot_name, plugin, slot_type, active, NOT catalog_xmin IS NULL AS catalog_xmin_set, xmin IS NULl AS data_xmin_not_set, - pg_xlog_location_diff(restart_lsn, '0/01000000') > 0 AS some_wal + pg_wal_location_diff(restart_lsn, '0/01000000') > 0 AS some_wal FROM pg_replication_slots; /* diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml index d7df91090d..5f009ee3d0 100644 --- a/doc/src/sgml/backup.sgml +++ b/doc/src/sgml/backup.sgml @@ -726,7 +726,7 @@ test ! -f /mnt/server/archivedir/00000001000000A900000065 && cp pg_wal/0 Also, you can force a segment switch manually with - pg_switch_xlog if you want to ensure that a + pg_switch_wal if you want to ensure that a just-finished transaction is archived as soon as possible. Other utility functions related to WAL management are listed in . diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 9e2170ea4b..d7738b18b7 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -17952,13 +17952,13 @@ SELECT set_config('log_statement_stats', 'off', false); pg_create_restore_point - pg_current_xlog_flush_location + pg_current_wal_flush_location - pg_current_xlog_insert_location + pg_current_wal_insert_location - pg_current_xlog_location + pg_current_wal_location pg_start_backup @@ -17973,16 +17973,16 @@ SELECT set_config('log_statement_stats', 'off', false); pg_backup_start_time - pg_switch_xlog + pg_switch_wal - pg_xlogfile_name + pg_walfile_name - pg_xlogfile_name_offset + pg_walfile_name_offset - pg_xlog_location_diff + pg_wal_location_diff @@ -17990,7 +17990,7 @@ SELECT set_config('log_statement_stats', 'off', false); linkend="functions-admin-backup-table"> assist in making on-line backups. These functions cannot be executed during recovery (except pg_is_in_backup, pg_backup_start_time - and pg_xlog_location_diff). + and pg_wal_location_diff). @@ -18011,21 +18011,21 @@ SELECT set_config('log_statement_stats', 'off', false); - pg_current_xlog_flush_location() + pg_current_wal_flush_location() pg_lsn Get current transaction log flush location - pg_current_xlog_insert_location() + pg_current_wal_insert_location() pg_lsn Get current transaction log insert location - pg_current_xlog_location() + pg_current_wal_location() pg_lsn Get current transaction log write location @@ -18067,28 +18067,28 @@ SELECT set_config('log_statement_stats', 'off', false); - pg_switch_xlog() + pg_switch_wal() pg_lsn Force switch to a new transaction log file (restricted to superusers by default, but other users can be granted EXECUTE to run the function) - pg_xlogfile_name(location pg_lsn) + pg_walfile_name(location pg_lsn) text Convert transaction log location string to file name - pg_xlogfile_name_offset(location pg_lsn) + pg_walfile_name_offset(location pg_lsn) text, integer Convert transaction log location string to file name and decimal byte offset within file - pg_xlog_location_diff(location pg_lsn, location pg_lsn) + pg_wal_location_diff(location pg_lsn, location pg_lsn) numeric Calculate the difference between two transaction log locations @@ -18146,11 +18146,11 @@ postgres=# select pg_start_backup('label_goes_here'); - pg_switch_xlog moves to the next transaction log file, allowing the + pg_switch_wal moves to the next transaction log file, allowing the current file to be archived (assuming you are using continuous archiving). The return value is the ending transaction log location + 1 within the just-completed transaction log file. If there has been no transaction log activity since the last transaction log switch, - pg_switch_xlog does nothing and returns the start location + pg_switch_wal does nothing and returns the start location of the transaction log file currently in use. @@ -18165,10 +18165,10 @@ postgres=# select pg_start_backup('label_goes_here'); - pg_current_xlog_location displays the current transaction log write + pg_current_wal_location displays the current transaction log write location in the same format used by the above functions. Similarly, - pg_current_xlog_insert_location displays the current transaction log - insertion point and pg_current_xlog_flush_location displays the + pg_current_wal_insert_location displays the current transaction log + insertion point and pg_current_wal_flush_location displays the current transaction log flush point. The insertion point is the logical end of the transaction log at any instant, while the write location is the end of what has actually been written out from the server's internal buffers and flush @@ -18181,17 +18181,17 @@ postgres=# select pg_start_backup('label_goes_here'); - You can use pg_xlogfile_name_offset to extract the + You can use pg_walfile_name_offset to extract the corresponding transaction log file name and byte offset from the results of any of the above functions. For example: -postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); +postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup()); file_name | file_offset --------------------------+------------- 00000001000000000000000D | 4039624 (1 row) - Similarly, pg_xlogfile_name extracts just the transaction log file name. + Similarly, pg_walfile_name extracts just the transaction log file name. When the given transaction log location is exactly at a transaction log file boundary, both these functions return the name of the preceding transaction log file. This is usually the desired behavior for managing transaction log archiving @@ -18200,7 +18200,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); - pg_xlog_location_diff calculates the difference in bytes + pg_wal_location_diff calculates the difference in bytes between two transaction log locations. It can be used with pg_stat_replication or some functions shown in to get the replication lag. @@ -18220,10 +18220,10 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); pg_is_in_recovery - pg_last_xlog_receive_location + pg_last_wal_receive_location - pg_last_xlog_replay_location + pg_last_wal_replay_location pg_last_xact_replay_timestamp @@ -18255,7 +18255,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); - pg_last_xlog_receive_location() + pg_last_wal_receive_location() pg_lsn Get last transaction log location received and synced to disk by @@ -18269,7 +18269,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); - pg_last_xlog_replay_location() + pg_last_wal_replay_location() pg_lsn Get last transaction log location replayed during recovery. @@ -18301,13 +18301,13 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup());
- pg_is_xlog_replay_paused + pg_is_wal_replay_paused - pg_xlog_replay_pause + pg_wal_replay_pause - pg_xlog_replay_resume + pg_wal_replay_resume @@ -18327,7 +18327,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); - pg_is_xlog_replay_paused() + pg_is_wal_replay_paused() bool True if recovery is paused. @@ -18335,7 +18335,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); - pg_xlog_replay_pause() + pg_wal_replay_pause() void Pauses recovery immediately (restricted to superusers by default, but other users can be granted EXECUTE to run the function). @@ -18343,7 +18343,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); - pg_xlog_replay_resume() + pg_wal_replay_resume() void Restarts recovery if it was paused (restricted to superusers by default, but other users can be granted EXECUTE to run the function). @@ -18492,7 +18492,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); pg_create_physical_replication_slot(slot_name name , immediately_reserve boolean, temporary boolean) - (slot_name name, xlog_position pg_lsn) + (slot_name name, wal_position pg_lsn) Creates a new physical replication slot named @@ -18536,7 +18536,7 @@ postgres=# SELECT * FROM pg_xlogfile_name_offset(pg_stop_backup()); pg_create_logical_replication_slot(slot_name name, plugin name , temporary boolean) - (slot_name name, xlog_position pg_lsn) + (slot_name name, wal_position pg_lsn) Creates a new logical (decoding) replication slot named diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml index a1a9532088..48de2ced23 100644 --- a/doc/src/sgml/high-availability.sgml +++ b/doc/src/sgml/high-availability.sgml @@ -853,8 +853,8 @@ primary_conninfo = 'host=192.168.1.50 port=5432 user=foo password=foopass' standby. You can calculate this lag by comparing the current WAL write location on the primary with the last WAL location received by the standby. They can be retrieved using - pg_current_xlog_location on the primary and the - pg_last_xlog_receive_location on the standby, + pg_current_wal_location on the primary and the + pg_last_wal_receive_location on the standby, respectively (see and for details). The last WAL receive location in the standby is also displayed in the @@ -865,10 +865,10 @@ primary_conninfo = 'host=192.168.1.50 port=5432 user=foo password=foopass' You can retrieve a list of WAL sender processes via the pg_stat_replication view. Large differences between - pg_current_xlog_location and sent_location field + pg_current_wal_location and sent_location field might indicate that the master server is under heavy load, while differences between sent_location and - pg_last_xlog_receive_location on the standby might indicate + pg_last_wal_receive_location on the standby might indicate network delay, or that the standby is under heavy load. @@ -929,7 +929,7 @@ primary_conninfo = 'host=192.168.1.50 port=5432 user=foo password=foopass' You can create a replication slot like this: postgres=# SELECT * FROM pg_create_physical_replication_slot('node_a_slot'); - slot_name | xlog_position + slot_name | wal_position -------------+--------------- node_a_slot | @@ -1587,7 +1587,7 @@ if (!triggered) - An external program can call the pg_xlogfile_name_offset() + An external program can call the pg_walfile_name_offset() function (see ) to find out the file name and the exact byte offset within it of the current end of WAL. It can then access the WAL file directly @@ -2225,7 +2225,7 @@ LOG: database system is ready to accept read only connections WAL file control commands will not work during recovery, - e.g. pg_start_backup, pg_switch_xlog etc. + e.g. pg_start_backup, pg_switch_wal etc. diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 484915d042..c4dff3b9ff 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -56,7 +56,7 @@ postgres=# -- Create a slot named 'regression_slot' using the output plugin 'test_decoding' postgres=# SELECT * FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding'); - slot_name | xlog_position + slot_name | wal_position -----------------+--------------- regression_slot | 0/16B1970 (1 row) diff --git a/doc/src/sgml/recovery-config.sgml b/doc/src/sgml/recovery-config.sgml index 8c24ae2174..a91864bf62 100644 --- a/doc/src/sgml/recovery-config.sgml +++ b/doc/src/sgml/recovery-config.sgml @@ -321,7 +321,7 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows to be executed against the database to check if this recovery target is the most desirable point for recovery. The paused state can be resumed by - using pg_xlog_replay_resume() (see + using pg_wal_replay_resume() (see ), which then causes recovery to end. If this recovery target is not the desired stopping point, then shut down the server, change the diff --git a/src/backend/access/transam/recovery.conf.sample b/src/backend/access/transam/recovery.conf.sample index 7a16751541..d5cb437e50 100644 --- a/src/backend/access/transam/recovery.conf.sample +++ b/src/backend/access/transam/recovery.conf.sample @@ -98,7 +98,7 @@ # # If recovery_target_action = 'pause', recovery will pause when the # recovery target is reached. The pause state will continue until -# pg_xlog_replay_resume() is called. This setting has no effect if +# pg_wal_replay_resume() is called. This setting has no effect if # no recovery target is set. If hot_standby is not enabled then the # server will shutdown instead, though you may request this in # any case by specifying 'shutdown'. diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index cc8b83fa8d..b91a6ffd53 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -5870,7 +5870,7 @@ recoveryPausesHere(void) ereport(LOG, (errmsg("recovery has paused"), - errhint("Execute pg_xlog_replay_resume() to continue."))); + errhint("Execute pg_wal_replay_resume() to continue."))); while (RecoveryIsPaused()) { diff --git a/src/backend/access/transam/xlogfuncs.c b/src/backend/access/transam/xlogfuncs.c index 63e6552ce7..27c0c561a8 100644 --- a/src/backend/access/transam/xlogfuncs.c +++ b/src/backend/access/transam/xlogfuncs.c @@ -276,13 +276,13 @@ pg_stop_backup_v2(PG_FUNCTION_ARGS) } /* - * pg_switch_xlog: switch to next xlog file + * pg_switch_wal: switch to next xlog file * * Permission checking for this function is managed through the normal * GRANT system. */ Datum -pg_switch_xlog(PG_FUNCTION_ARGS) +pg_switch_wal(PG_FUNCTION_ARGS) { XLogRecPtr switchpoint; @@ -348,7 +348,7 @@ pg_create_restore_point(PG_FUNCTION_ARGS) * to the kernel, but is not necessarily synced to disk. */ Datum -pg_current_xlog_location(PG_FUNCTION_ARGS) +pg_current_wal_location(PG_FUNCTION_ARGS) { XLogRecPtr current_recptr; @@ -369,7 +369,7 @@ pg_current_xlog_location(PG_FUNCTION_ARGS) * This function is mostly for debugging purposes. */ Datum -pg_current_xlog_insert_location(PG_FUNCTION_ARGS) +pg_current_wal_insert_location(PG_FUNCTION_ARGS) { XLogRecPtr current_recptr; @@ -390,7 +390,7 @@ pg_current_xlog_insert_location(PG_FUNCTION_ARGS) * This function is mostly for debugging purposes. */ Datum -pg_current_xlog_flush_location(PG_FUNCTION_ARGS) +pg_current_wal_flush_location(PG_FUNCTION_ARGS) { XLogRecPtr current_recptr; @@ -412,7 +412,7 @@ pg_current_xlog_flush_location(PG_FUNCTION_ARGS) * and synced to disk by walreceiver. */ Datum -pg_last_xlog_receive_location(PG_FUNCTION_ARGS) +pg_last_wal_receive_location(PG_FUNCTION_ARGS) { XLogRecPtr recptr; @@ -431,7 +431,7 @@ pg_last_xlog_receive_location(PG_FUNCTION_ARGS) * connections during recovery. */ Datum -pg_last_xlog_replay_location(PG_FUNCTION_ARGS) +pg_last_wal_replay_location(PG_FUNCTION_ARGS) { XLogRecPtr recptr; @@ -452,7 +452,7 @@ pg_last_xlog_replay_location(PG_FUNCTION_ARGS) * expected usage is to determine which xlog file(s) are ready to archive. */ Datum -pg_xlogfile_name_offset(PG_FUNCTION_ARGS) +pg_walfile_name_offset(PG_FUNCTION_ARGS) { XLogSegNo xlogsegno; uint32 xrecoff; @@ -468,7 +468,7 @@ pg_xlogfile_name_offset(PG_FUNCTION_ARGS) ereport(ERROR, (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), errmsg("recovery is in progress"), - errhint("pg_xlogfile_name_offset() cannot be executed during recovery."))); + errhint("pg_walfile_name_offset() cannot be executed during recovery."))); /* * Construct a tuple descriptor for the result row. This must match this @@ -514,7 +514,7 @@ pg_xlogfile_name_offset(PG_FUNCTION_ARGS) * such as is returned by pg_stop_backup() or pg_xlog_switch(). */ Datum -pg_xlogfile_name(PG_FUNCTION_ARGS) +pg_walfile_name(PG_FUNCTION_ARGS) { XLogSegNo xlogsegno; XLogRecPtr locationpoint = PG_GETARG_LSN(0); @@ -524,7 +524,7 @@ pg_xlogfile_name(PG_FUNCTION_ARGS) ereport(ERROR, (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), errmsg("recovery is in progress"), - errhint("pg_xlogfile_name() cannot be executed during recovery."))); + errhint("pg_walfile_name() cannot be executed during recovery."))); XLByteToPrevSeg(locationpoint, xlogsegno); XLogFileName(xlogfilename, ThisTimeLineID, xlogsegno); @@ -533,13 +533,13 @@ pg_xlogfile_name(PG_FUNCTION_ARGS) } /* - * pg_xlog_replay_pause - pause recovery now + * pg_wal_replay_pause - pause recovery now * * Permission checking for this function is managed through the normal * GRANT system. */ Datum -pg_xlog_replay_pause(PG_FUNCTION_ARGS) +pg_wal_replay_pause(PG_FUNCTION_ARGS) { if (!RecoveryInProgress()) ereport(ERROR, @@ -553,13 +553,13 @@ pg_xlog_replay_pause(PG_FUNCTION_ARGS) } /* - * pg_xlog_replay_resume - resume recovery now + * pg_wal_replay_resume - resume recovery now * * Permission checking for this function is managed through the normal * GRANT system. */ Datum -pg_xlog_replay_resume(PG_FUNCTION_ARGS) +pg_wal_replay_resume(PG_FUNCTION_ARGS) { if (!RecoveryInProgress()) ereport(ERROR, @@ -573,10 +573,10 @@ pg_xlog_replay_resume(PG_FUNCTION_ARGS) } /* - * pg_is_xlog_replay_paused + * pg_is_wal_replay_paused */ Datum -pg_is_xlog_replay_paused(PG_FUNCTION_ARGS) +pg_is_wal_replay_paused(PG_FUNCTION_ARGS) { if (!RecoveryInProgress()) ereport(ERROR, @@ -618,7 +618,7 @@ pg_is_in_recovery(PG_FUNCTION_ARGS) * Compute the difference in bytes between two WAL locations. */ Datum -pg_xlog_location_diff(PG_FUNCTION_ARGS) +pg_wal_location_diff(PG_FUNCTION_ARGS) { Datum result; diff --git a/src/backend/catalog/system_views.sql b/src/backend/catalog/system_views.sql index 907e0fb630..b4c2425179 100644 --- a/src/backend/catalog/system_views.sql +++ b/src/backend/catalog/system_views.sql @@ -1028,7 +1028,7 @@ AS 'pg_logical_slot_peek_binary_changes'; CREATE OR REPLACE FUNCTION pg_create_physical_replication_slot( IN slot_name name, IN immediately_reserve boolean DEFAULT false, IN temporary boolean DEFAULT false, - OUT slot_name name, OUT xlog_position pg_lsn) + OUT slot_name name, OUT wal_position pg_lsn) RETURNS RECORD LANGUAGE INTERNAL STRICT VOLATILE @@ -1037,7 +1037,7 @@ AS 'pg_create_physical_replication_slot'; CREATE OR REPLACE FUNCTION pg_create_logical_replication_slot( IN slot_name name, IN plugin name, IN temporary boolean DEFAULT false, - OUT slot_name text, OUT xlog_position pg_lsn) + OUT slot_name text, OUT wal_position pg_lsn) RETURNS RECORD LANGUAGE INTERNAL STRICT VOLATILE @@ -1085,9 +1085,9 @@ REVOKE EXECUTE ON FUNCTION pg_start_backup(text, boolean, boolean) FROM public; REVOKE EXECUTE ON FUNCTION pg_stop_backup() FROM public; REVOKE EXECUTE ON FUNCTION pg_stop_backup(boolean) FROM public; REVOKE EXECUTE ON FUNCTION pg_create_restore_point(text) FROM public; -REVOKE EXECUTE ON FUNCTION pg_switch_xlog() FROM public; -REVOKE EXECUTE ON FUNCTION pg_xlog_replay_pause() FROM public; -REVOKE EXECUTE ON FUNCTION pg_xlog_replay_resume() FROM public; +REVOKE EXECUTE ON FUNCTION pg_switch_wal() FROM public; +REVOKE EXECUTE ON FUNCTION pg_wal_replay_pause() FROM public; +REVOKE EXECUTE ON FUNCTION pg_wal_replay_resume() FROM public; REVOKE EXECUTE ON FUNCTION pg_rotate_logfile() FROM public; REVOKE EXECUTE ON FUNCTION pg_reload_conf() FROM public; diff --git a/src/bin/pg_basebackup/t/030_pg_recvlogical.pl b/src/bin/pg_basebackup/t/030_pg_recvlogical.pl index dca5ef2181..b43176fdc6 100644 --- a/src/bin/pg_basebackup/t/030_pg_recvlogical.pl +++ b/src/bin/pg_basebackup/t/030_pg_recvlogical.pl @@ -39,7 +39,7 @@ isnt($slot->{'restart_lsn'}, '', 'restart lsn is defined for new slot'); $node->psql('postgres', 'CREATE TABLE test_table(x integer)'); $node->psql('postgres', 'INSERT INTO test_table(x) SELECT y FROM generate_series(1, 10) a(y);'); -my $nextlsn = $node->safe_psql('postgres', 'SELECT pg_current_xlog_insert_location()'); +my $nextlsn = $node->safe_psql('postgres', 'SELECT pg_current_wal_insert_location()'); chomp($nextlsn); $node->command_ok(['pg_recvlogical', '-S', 'test', '-d', $node->connstr('postgres'), '--start', '--endpos', "$nextlsn", '--no-loop', '-f', '-'], diff --git a/src/bin/pg_rewind/RewindTest.pm b/src/bin/pg_rewind/RewindTest.pm index 1c482617ad..c67212ff7a 100644 --- a/src/bin/pg_rewind/RewindTest.pm +++ b/src/bin/pg_rewind/RewindTest.pm @@ -156,7 +156,7 @@ sub promote_standby # Wait for the standby to receive and write all WAL. my $wal_received_query = -"SELECT pg_current_xlog_location() = write_location FROM pg_stat_replication WHERE application_name = 'rewind_standby';"; +"SELECT pg_current_wal_location() = write_location FROM pg_stat_replication WHERE application_name = 'rewind_standby';"; $node_master->poll_query_until('postgres', $wal_received_query) or die "Timed out while waiting for standby to receive and write WAL"; diff --git a/src/bin/pg_rewind/libpq_fetch.c b/src/bin/pg_rewind/libpq_fetch.c index a903849ee4..d2374201c6 100644 --- a/src/bin/pg_rewind/libpq_fetch.c +++ b/src/bin/pg_rewind/libpq_fetch.c @@ -121,7 +121,7 @@ run_simple_query(const char *sql) } /* - * Calls pg_current_xlog_insert_location() function + * Calls pg_current_wal_insert_location() function */ XLogRecPtr libpqGetCurrentXlogInsertLocation(void) @@ -131,7 +131,7 @@ libpqGetCurrentXlogInsertLocation(void) uint32 lo; char *val; - val = run_simple_query("SELECT pg_current_xlog_insert_location()"); + val = run_simple_query("SELECT pg_current_wal_insert_location()"); if (sscanf(val, "%X/%X", &hi, &lo) != 2) pg_fatal("unrecognized result \"%s\" for current WAL insert location\n", val); diff --git a/src/include/catalog/catversion.h b/src/include/catalog/catversion.h index 82511c2db8..abb4aab9f8 100644 --- a/src/include/catalog/catversion.h +++ b/src/include/catalog/catversion.h @@ -53,6 +53,6 @@ */ /* yyyymmddN */ -#define CATALOG_VERSION_NO 201701301 +#define CATALOG_VERSION_NO 201701309 #endif diff --git a/src/include/catalog/pg_proc.h b/src/include/catalog/pg_proc.h index 05652e86c2..f6c0f23982 100644 --- a/src/include/catalog/pg_proc.h +++ b/src/include/catalog/pg_proc.h @@ -3149,23 +3149,23 @@ DATA(insert OID = 3813 ( pg_is_in_backup PGNSP PGUID 12 1 0 0 0 f f f f t f v s DESCR("true if server is in online backup"); DATA(insert OID = 3814 ( pg_backup_start_time PGNSP PGUID 12 1 0 0 0 f f f f t f s s 0 0 1184 "" _null_ _null_ _null_ _null_ _null_ pg_backup_start_time _null_ _null_ _null_ )); DESCR("start time of an online backup"); -DATA(insert OID = 2848 ( pg_switch_xlog PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_switch_xlog _null_ _null_ _null_ )); -DESCR("switch to new xlog file"); +DATA(insert OID = 2848 ( pg_switch_wal PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_switch_wal _null_ _null_ _null_ )); +DESCR("switch to new wal file"); DATA(insert OID = 3098 ( pg_create_restore_point PGNSP PGUID 12 1 0 0 0 f f f f t f v s 1 0 3220 "25" _null_ _null_ _null_ _null_ _null_ pg_create_restore_point _null_ _null_ _null_ )); DESCR("create a named restore point"); -DATA(insert OID = 2849 ( pg_current_xlog_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_current_xlog_location _null_ _null_ _null_ )); -DESCR("current xlog write location"); -DATA(insert OID = 2852 ( pg_current_xlog_insert_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_current_xlog_insert_location _null_ _null_ _null_ )); -DESCR("current xlog insert location"); -DATA(insert OID = 3330 ( pg_current_xlog_flush_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_current_xlog_flush_location _null_ _null_ _null_ )); -DESCR("current xlog flush location"); -DATA(insert OID = 2850 ( pg_xlogfile_name_offset PGNSP PGUID 12 1 0 0 0 f f f f t f i s 1 0 2249 "3220" "{3220,25,23}" "{i,o,o}" "{wal_location,file_name,file_offset}" _null_ _null_ pg_xlogfile_name_offset _null_ _null_ _null_ )); -DESCR("xlog filename and byte offset, given an xlog location"); -DATA(insert OID = 2851 ( pg_xlogfile_name PGNSP PGUID 12 1 0 0 0 f f f f t f i s 1 0 25 "3220" _null_ _null_ _null_ _null_ _null_ pg_xlogfile_name _null_ _null_ _null_ )); -DESCR("xlog filename, given an xlog location"); +DATA(insert OID = 2849 ( pg_current_wal_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_current_wal_location _null_ _null_ _null_ )); +DESCR("current wal write location"); +DATA(insert OID = 2852 ( pg_current_wal_insert_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_current_wal_insert_location _null_ _null_ _null_ )); +DESCR("current wal insert location"); +DATA(insert OID = 3330 ( pg_current_wal_flush_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_current_wal_flush_location _null_ _null_ _null_ )); +DESCR("current wal flush location"); +DATA(insert OID = 2850 ( pg_walfile_name_offset PGNSP PGUID 12 1 0 0 0 f f f f t f i s 1 0 2249 "3220" "{3220,25,23}" "{i,o,o}" "{wal_location,file_name,file_offset}" _null_ _null_ pg_walfile_name_offset _null_ _null_ _null_ )); +DESCR("wal filename and byte offset, given an wal location"); +DATA(insert OID = 2851 ( pg_walfile_name PGNSP PGUID 12 1 0 0 0 f f f f t f i s 1 0 25 "3220" _null_ _null_ _null_ _null_ _null_ pg_walfile_name _null_ _null_ _null_ )); +DESCR("wal filename, given an wal location"); -DATA(insert OID = 3165 ( pg_xlog_location_diff PGNSP PGUID 12 1 0 0 0 f f f f t f i s 2 0 1700 "3220 3220" _null_ _null_ _null_ _null_ _null_ pg_xlog_location_diff _null_ _null_ _null_ )); -DESCR("difference in bytes, given two xlog locations"); +DATA(insert OID = 3165 ( pg_wal_location_diff PGNSP PGUID 12 1 0 0 0 f f f f t f i s 2 0 1700 "3220 3220" _null_ _null_ _null_ _null_ _null_ pg_wal_location_diff _null_ _null_ _null_ )); +DESCR("difference in bytes, given two wal locations"); DATA(insert OID = 3809 ( pg_export_snapshot PGNSP PGUID 12 1 0 0 0 f f f f t f v u 0 0 25 "" _null_ _null_ _null_ _null_ _null_ pg_export_snapshot _null_ _null_ _null_ )); DESCR("export a snapshot"); @@ -3173,19 +3173,19 @@ DESCR("export a snapshot"); DATA(insert OID = 3810 ( pg_is_in_recovery PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 16 "" _null_ _null_ _null_ _null_ _null_ pg_is_in_recovery _null_ _null_ _null_ )); DESCR("true if server is in recovery"); -DATA(insert OID = 3820 ( pg_last_xlog_receive_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_last_xlog_receive_location _null_ _null_ _null_ )); -DESCR("current xlog flush location"); -DATA(insert OID = 3821 ( pg_last_xlog_replay_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_last_xlog_replay_location _null_ _null_ _null_ )); -DESCR("last xlog replay location"); +DATA(insert OID = 3820 ( pg_last_wal_receive_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_last_wal_receive_location _null_ _null_ _null_ )); +DESCR("current wal flush location"); +DATA(insert OID = 3821 ( pg_last_wal_replay_location PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_last_wal_replay_location _null_ _null_ _null_ )); +DESCR("last wal replay location"); DATA(insert OID = 3830 ( pg_last_xact_replay_timestamp PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 1184 "" _null_ _null_ _null_ _null_ _null_ pg_last_xact_replay_timestamp _null_ _null_ _null_ )); DESCR("timestamp of last replay xact"); -DATA(insert OID = 3071 ( pg_xlog_replay_pause PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 2278 "" _null_ _null_ _null_ _null_ _null_ pg_xlog_replay_pause _null_ _null_ _null_ )); -DESCR("pause xlog replay"); -DATA(insert OID = 3072 ( pg_xlog_replay_resume PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 2278 "" _null_ _null_ _null_ _null_ _null_ pg_xlog_replay_resume _null_ _null_ _null_ )); -DESCR("resume xlog replay, if it was paused"); -DATA(insert OID = 3073 ( pg_is_xlog_replay_paused PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 16 "" _null_ _null_ _null_ _null_ _null_ pg_is_xlog_replay_paused _null_ _null_ _null_ )); -DESCR("true if xlog replay is paused"); +DATA(insert OID = 3071 ( pg_wal_replay_pause PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 2278 "" _null_ _null_ _null_ _null_ _null_ pg_wal_replay_pause _null_ _null_ _null_ )); +DESCR("pause wal replay"); +DATA(insert OID = 3072 ( pg_wal_replay_resume PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 2278 "" _null_ _null_ _null_ _null_ _null_ pg_wal_replay_resume _null_ _null_ _null_ )); +DESCR("resume wal replay, if it was paused"); +DATA(insert OID = 3073 ( pg_is_wal_replay_paused PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 16 "" _null_ _null_ _null_ _null_ _null_ pg_is_wal_replay_paused _null_ _null_ _null_ )); +DESCR("true if wal replay is paused"); DATA(insert OID = 2621 ( pg_reload_conf PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 16 "" _null_ _null_ _null_ _null_ _null_ pg_reload_conf _null_ _null_ _null_ )); DESCR("reload configuration files"); @@ -5187,13 +5187,13 @@ DATA(insert OID = 5016 ( spg_box_quad_leaf_consistent PGNSP PGUID 12 1 0 0 0 f DESCR("SP-GiST support for quad tree over box"); /* replication slots */ -DATA(insert OID = 3779 ( pg_create_physical_replication_slot PGNSP PGUID 12 1 0 0 0 f f f f t f v u 3 0 2249 "19 16 16" "{19,16,16,19,3220}" "{i,i,i,o,o}" "{slot_name,immediately_reserve,temporary,slot_name,xlog_position}" _null_ _null_ pg_create_physical_replication_slot _null_ _null_ _null_ )); +DATA(insert OID = 3779 ( pg_create_physical_replication_slot PGNSP PGUID 12 1 0 0 0 f f f f t f v u 3 0 2249 "19 16 16" "{19,16,16,19,3220}" "{i,i,i,o,o}" "{slot_name,immediately_reserve,temporary,slot_name,wal_position}" _null_ _null_ pg_create_physical_replication_slot _null_ _null_ _null_ )); DESCR("create a physical replication slot"); DATA(insert OID = 3780 ( pg_drop_replication_slot PGNSP PGUID 12 1 0 0 0 f f f f t f v u 1 0 2278 "19" _null_ _null_ _null_ _null_ _null_ pg_drop_replication_slot _null_ _null_ _null_ )); DESCR("drop a replication slot"); DATA(insert OID = 3781 ( pg_get_replication_slots PGNSP PGUID 12 1 10 0 0 f f f f f t s s 0 0 2249 "" "{19,19,25,26,16,16,23,28,28,3220,3220}" "{o,o,o,o,o,o,o,o,o,o,o}" "{slot_name,plugin,slot_type,datoid,temporary,active,active_pid,xmin,catalog_xmin,restart_lsn,confirmed_flush_lsn}" _null_ _null_ pg_get_replication_slots _null_ _null_ _null_ )); DESCR("information about replication slots currently in use"); -DATA(insert OID = 3786 ( pg_create_logical_replication_slot PGNSP PGUID 12 1 0 0 0 f f f f t f v u 3 0 2249 "19 19 16" "{19,19,16,25,3220}" "{i,i,i,o,o}" "{slot_name,plugin,temporary,slot_name,xlog_position}" _null_ _null_ pg_create_logical_replication_slot _null_ _null_ _null_ )); +DATA(insert OID = 3786 ( pg_create_logical_replication_slot PGNSP PGUID 12 1 0 0 0 f f f f t f v u 3 0 2249 "19 19 16" "{19,19,16,25,3220}" "{i,i,i,o,o}" "{slot_name,plugin,temporary,slot_name,wal_position}" _null_ _null_ pg_create_logical_replication_slot _null_ _null_ _null_ )); DESCR("set up a logical replication slot"); DATA(insert OID = 3782 ( pg_logical_slot_get_changes PGNSP PGUID 12 1000 1000 25 0 f f f f f t v u 4 0 2249 "19 3220 23 1009" "{19,3220,23,1009,3220,28,25}" "{i,i,i,v,o,o,o}" "{slot_name,upto_lsn,upto_nchanges,options,location,xid,data}" _null_ _null_ pg_logical_slot_get_changes _null_ _null_ _null_ )); DESCR("get changes from replication slot"); diff --git a/src/test/modules/commit_ts/t/002_standby.pl b/src/test/modules/commit_ts/t/002_standby.pl index ff60044540..203b75d35b 100644 --- a/src/test/modules/commit_ts/t/002_standby.pl +++ b/src/test/modules/commit_ts/t/002_standby.pl @@ -31,9 +31,9 @@ my $master_ts = $master->safe_psql('postgres', qq{SELECT ts.* FROM pg_class, pg_xact_commit_timestamp(xmin) AS ts WHERE relname = 't10'} ); my $master_lsn = - $master->safe_psql('postgres', 'select pg_current_xlog_location()'); + $master->safe_psql('postgres', 'select pg_current_wal_location()'); $standby->poll_query_until('postgres', - qq{SELECT '$master_lsn'::pg_lsn <= pg_last_xlog_replay_location()}) + qq{SELECT '$master_lsn'::pg_lsn <= pg_last_wal_replay_location()}) or die "slave never caught up"; my $standby_ts = $standby->safe_psql('postgres', @@ -45,9 +45,9 @@ $master->append_conf('postgresql.conf', 'track_commit_timestamp = off'); $master->restart; $master->safe_psql('postgres', 'checkpoint'); $master_lsn = - $master->safe_psql('postgres', 'select pg_current_xlog_location()'); + $master->safe_psql('postgres', 'select pg_current_wal_location()'); $standby->poll_query_until('postgres', - qq{SELECT '$master_lsn'::pg_lsn <= pg_last_xlog_replay_location()}) + qq{SELECT '$master_lsn'::pg_lsn <= pg_last_wal_replay_location()}) or die "slave never caught up"; $standby->safe_psql('postgres', 'checkpoint'); diff --git a/src/test/modules/commit_ts/t/003_standby_2.pl b/src/test/modules/commit_ts/t/003_standby_2.pl index 1775b22dad..d7898b8355 100644 --- a/src/test/modules/commit_ts/t/003_standby_2.pl +++ b/src/test/modules/commit_ts/t/003_standby_2.pl @@ -30,9 +30,9 @@ $master->append_conf('postgresql.conf', 'track_commit_timestamp = off'); $master->restart; $master->safe_psql('postgres', 'checkpoint'); my $master_lsn = - $master->safe_psql('postgres', 'select pg_current_xlog_location()'); + $master->safe_psql('postgres', 'select pg_current_wal_location()'); $standby->poll_query_until('postgres', - qq{SELECT '$master_lsn'::pg_lsn <= pg_last_xlog_replay_location()}) + qq{SELECT '$master_lsn'::pg_lsn <= pg_last_wal_replay_location()}) or die "slave never caught up"; $standby->safe_psql('postgres', 'checkpoint'); diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm index 18d5d12454..4018f0af1f 100644 --- a/src/test/perl/PostgresNode.pm +++ b/src/test/perl/PostgresNode.pm @@ -1358,11 +1358,11 @@ mode must be specified. sub lsn { my ($self, $mode) = @_; - my %modes = ('insert' => 'pg_current_xlog_insert_location()', - 'flush' => 'pg_current_xlog_flush_location()', - 'write' => 'pg_current_xlog_location()', - 'receive' => 'pg_last_xlog_receive_location()', - 'replay' => 'pg_last_xlog_replay_location()'); + my %modes = ('insert' => 'pg_current_wal_insert_location()', + 'flush' => 'pg_current_wal_flush_location()', + 'write' => 'pg_current_wal_location()', + 'receive' => 'pg_last_wal_receive_location()', + 'replay' => 'pg_last_wal_replay_location()'); $mode = '' if !defined($mode); die "unknown mode for 'lsn': '$mode', valid modes are " . join(', ', keys %modes) diff --git a/src/test/recovery/t/002_archiving.pl b/src/test/recovery/t/002_archiving.pl index fc2bf7ee1d..83b43bf84d 100644 --- a/src/test/recovery/t/002_archiving.pl +++ b/src/test/recovery/t/002_archiving.pl @@ -33,10 +33,10 @@ $node_standby->start; $node_master->safe_psql('postgres', "CREATE TABLE tab_int AS SELECT generate_series(1,1000) AS a"); my $current_lsn = - $node_master->safe_psql('postgres', "SELECT pg_current_xlog_location();"); + $node_master->safe_psql('postgres', "SELECT pg_current_wal_location();"); # Force archiving of WAL file to make it present on master -$node_master->safe_psql('postgres', "SELECT pg_switch_xlog()"); +$node_master->safe_psql('postgres', "SELECT pg_switch_wal()"); # Add some more content, it should not be present on standby $node_master->safe_psql('postgres', @@ -44,7 +44,7 @@ $node_master->safe_psql('postgres', # Wait until necessary replay has been done on standby my $caughtup_query = - "SELECT '$current_lsn'::pg_lsn <= pg_last_xlog_replay_location()"; + "SELECT '$current_lsn'::pg_lsn <= pg_last_wal_replay_location()"; $node_standby->poll_query_until('postgres', $caughtup_query) or die "Timed out while waiting for standby to catch up"; diff --git a/src/test/recovery/t/003_recovery_targets.pl b/src/test/recovery/t/003_recovery_targets.pl index a82545bf6f..b7b0caae68 100644 --- a/src/test/recovery/t/003_recovery_targets.pl +++ b/src/test/recovery/t/003_recovery_targets.pl @@ -32,7 +32,7 @@ sub test_recovery_standby # Wait until standby has replayed enough data my $caughtup_query = - "SELECT '$until_lsn'::pg_lsn <= pg_last_xlog_replay_location()"; + "SELECT '$until_lsn'::pg_lsn <= pg_last_wal_replay_location()"; $node_standby->poll_query_until('postgres', $caughtup_query) or die "Timed out while waiting for standby to catch up"; @@ -57,7 +57,7 @@ $node_master->start; $node_master->safe_psql('postgres', "CREATE TABLE tab_int AS SELECT generate_series(1,1000) AS a"); my $lsn1 = - $node_master->safe_psql('postgres', "SELECT pg_current_xlog_location();"); + $node_master->safe_psql('postgres', "SELECT pg_current_wal_location();"); # Take backup from which all operations will be run $node_master->backup('my_backup'); @@ -67,14 +67,14 @@ $node_master->backup('my_backup'); $node_master->safe_psql('postgres', "INSERT INTO tab_int VALUES (generate_series(1001,2000))"); my $ret = $node_master->safe_psql('postgres', - "SELECT pg_current_xlog_location(), txid_current();"); + "SELECT pg_current_wal_location(), txid_current();"); my ($lsn2, $recovery_txid) = split /\|/, $ret; # More data, with recovery target timestamp $node_master->safe_psql('postgres', "INSERT INTO tab_int VALUES (generate_series(2001,3000))"); $ret = $node_master->safe_psql('postgres', - "SELECT pg_current_xlog_location(), now();"); + "SELECT pg_current_wal_location(), now();"); my ($lsn3, $recovery_time) = split /\|/, $ret; # Even more data, this time with a recovery target name @@ -82,22 +82,22 @@ $node_master->safe_psql('postgres', "INSERT INTO tab_int VALUES (generate_series(3001,4000))"); my $recovery_name = "my_target"; my $lsn4 = - $node_master->safe_psql('postgres', "SELECT pg_current_xlog_location();"); + $node_master->safe_psql('postgres', "SELECT pg_current_wal_location();"); $node_master->safe_psql('postgres', "SELECT pg_create_restore_point('$recovery_name');"); # And now for a recovery target LSN $node_master->safe_psql('postgres', "INSERT INTO tab_int VALUES (generate_series(4001,5000))"); -my $recovery_lsn = $node_master->safe_psql('postgres', "SELECT pg_current_xlog_location()"); +my $recovery_lsn = $node_master->safe_psql('postgres', "SELECT pg_current_wal_location()"); my $lsn5 = - $node_master->safe_psql('postgres', "SELECT pg_current_xlog_location();"); + $node_master->safe_psql('postgres', "SELECT pg_current_wal_location();"); $node_master->safe_psql('postgres', "INSERT INTO tab_int VALUES (generate_series(5001,6000))"); # Force archiving of WAL file -$node_master->safe_psql('postgres', "SELECT pg_switch_xlog()"); +$node_master->safe_psql('postgres', "SELECT pg_switch_wal()"); # Test recovery targets my @recovery_params = ("recovery_target = 'immediate'"); diff --git a/src/test/recovery/t/005_replay_delay.pl b/src/test/recovery/t/005_replay_delay.pl index 640295bfa8..cd9e8f5c12 100644 --- a/src/test/recovery/t/005_replay_delay.pl +++ b/src/test/recovery/t/005_replay_delay.pl @@ -42,7 +42,7 @@ $node_master->safe_psql('postgres', # Now wait for replay to complete on standby. We're done waiting when the # slave has replayed up to the previously saved master LSN. my $until_lsn = - $node_master->safe_psql('postgres', "SELECT pg_current_xlog_location()"); + $node_master->safe_psql('postgres', "SELECT pg_current_wal_location()"); my $remaining = 90; while ($remaining-- > 0) @@ -50,7 +50,7 @@ while ($remaining-- > 0) # Done waiting? my $replay_status = $node_standby->safe_psql('postgres', - "SELECT (pg_last_xlog_replay_location() - '$until_lsn'::pg_lsn) >= 0" + "SELECT (pg_last_wal_replay_location() - '$until_lsn'::pg_lsn) >= 0" ); last if $replay_status eq 't'; diff --git a/src/test/recovery/t/008_fsm_truncation.pl b/src/test/recovery/t/008_fsm_truncation.pl index 5220611e44..8aa8a4fe82 100644 --- a/src/test/recovery/t/008_fsm_truncation.pl +++ b/src/test/recovery/t/008_fsm_truncation.pl @@ -68,11 +68,11 @@ vacuum verbose testtab; $node_master->psql('postgres', 'checkpoint'); my $until_lsn = - $node_master->safe_psql('postgres', "SELECT pg_current_xlog_location();"); + $node_master->safe_psql('postgres', "SELECT pg_current_wal_location();"); # Wait long enough for standby to receive and apply all WAL my $caughtup_query = - "SELECT '$until_lsn'::pg_lsn <= pg_last_xlog_replay_location()"; + "SELECT '$until_lsn'::pg_lsn <= pg_last_wal_replay_location()"; $node_standby->poll_query_until('postgres', $caughtup_query) or die "Timed out while waiting for standby to catch up"; diff --git a/src/test/regress/expected/hs_standby_functions.out b/src/test/regress/expected/hs_standby_functions.out index 16d50a8285..e0af677ea1 100644 --- a/src/test/regress/expected/hs_standby_functions.out +++ b/src/test/regress/expected/hs_standby_functions.out @@ -15,7 +15,7 @@ select length(txid_current_snapshot()::text) >= 4; select pg_start_backup('should fail'); ERROR: recovery is in progress HINT: WAL control functions cannot be executed during recovery. -select pg_switch_xlog(); +select pg_switch_wal(); ERROR: recovery is in progress HINT: WAL control functions cannot be executed during recovery. select pg_stop_backup(); diff --git a/src/test/regress/sql/hs_primary_extremes.sql b/src/test/regress/sql/hs_primary_extremes.sql index 629efb4be5..2051e2e5cf 100644 --- a/src/test/regress/sql/hs_primary_extremes.sql +++ b/src/test/regress/sql/hs_primary_extremes.sql @@ -70,4 +70,4 @@ SELECT count(*) > 257 FROM pg_locks; COMMIT; SELECT hs_locks_drop(257); -SELECT pg_switch_xlog(); +SELECT pg_switch_wal(); diff --git a/src/test/regress/sql/hs_primary_setup.sql b/src/test/regress/sql/hs_primary_setup.sql index a00b367cbc..eeb4421307 100644 --- a/src/test/regress/sql/hs_primary_setup.sql +++ b/src/test/regress/sql/hs_primary_setup.sql @@ -22,4 +22,4 @@ insert into hs3 values (115); DROP sequence if exists hsseq; create sequence hsseq; -SELECT pg_switch_xlog(); +SELECT pg_switch_wal(); diff --git a/src/test/regress/sql/hs_standby_functions.sql b/src/test/regress/sql/hs_standby_functions.sql index 7577045f11..251bac0a43 100644 --- a/src/test/regress/sql/hs_standby_functions.sql +++ b/src/test/regress/sql/hs_standby_functions.sql @@ -10,7 +10,7 @@ select txid_current(); select length(txid_current_snapshot()::text) >= 4; select pg_start_backup('should fail'); -select pg_switch_xlog(); +select pg_switch_wal(); select pg_stop_backup(); -- should return no rows diff --git a/src/test/subscription/t/001_rep_changes.pl b/src/test/subscription/t/001_rep_changes.pl index b51740bcd4..fa50e495a5 100644 --- a/src/test/subscription/t/001_rep_changes.pl +++ b/src/test/subscription/t/001_rep_changes.pl @@ -52,7 +52,7 @@ $node_subscriber->safe_psql('postgres', # Wait for subscriber to finish initialization my $caughtup_query = -"SELECT pg_current_xlog_location() <= replay_location FROM pg_stat_replication WHERE application_name = '$appname';"; +"SELECT pg_current_wal_location() <= replay_location FROM pg_stat_replication WHERE application_name = '$appname';"; $node_publisher->poll_query_until('postgres', $caughtup_query) or die "Timed out while waiting for subscriber to catch up"; diff --git a/src/test/subscription/t/002_types.pl b/src/test/subscription/t/002_types.pl index 9064eb4c6d..f44e1e671d 100644 --- a/src/test/subscription/t/002_types.pl +++ b/src/test/subscription/t/002_types.pl @@ -107,7 +107,7 @@ $node_subscriber->safe_psql('postgres', # Wait for subscriber to finish initialization my $caughtup_query = -"SELECT pg_current_xlog_location() <= replay_location FROM pg_stat_replication WHERE application_name = '$appname';"; +"SELECT pg_current_wal_location() <= replay_location FROM pg_stat_replication WHERE application_name = '$appname';"; $node_publisher->poll_query_until('postgres', $caughtup_query) or die "Timed out while waiting for subscriber to catch up";