rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make oldSnapshotControl a pointer to a volatile structure 

It was incorrectly declared as a volatile pointer to a non-volatile
structure.  Eliminate the OldSnapshotControl struct definition; it
is really not needed.  Pointed out by Tom Lane.

While at it, add OldSnapshotControlData to pgindent's list of
structures.
This commit is contained in:
Kevin Grittner 2016-04-11 15:43:52 -05:00
parent d8ed83cd7f
commit 80647bf65a
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/utils/time/snapmgr.c
View File

@ -117,9 +117,7 @@ typedef struct OldSnapshotControlData
TransactionId xid_by_minute[FLEXIBLE_ARRAY_MEMBER]; TransactionId xid_by_minute[FLEXIBLE_ARRAY_MEMBER];
} OldSnapshotControlData; } OldSnapshotControlData;
typedef struct OldSnapshotControlData *OldSnapshotControl; static volatile OldSnapshotControlData *oldSnapshotControl;
static volatile OldSnapshotControl oldSnapshotControl;
/* /*
@ -259,9 +257,9 @@ SnapMgrInit(void)
bool found; bool found;
/* /*
* Create or attach to the OldSnapshotControl structure. * Create or attach to the OldSnapshotControlData structure.
*/ */
oldSnapshotControl = (OldSnapshotControl) oldSnapshotControl = (volatile OldSnapshotControlData *)
ShmemInitStruct("OldSnapshotControlData", ShmemInitStruct("OldSnapshotControlData",
SnapMgrShmemSize(), &found); SnapMgrShmemSize(), &found);

1
src/tools/pgindent/typedefs.list
View File

@ -1175,6 +1175,7 @@ Oid
OidOptions OidOptions
OkeysState OkeysState
OldSerXidControl OldSerXidControl
OldSnapshotControlData
OldToNewMapping OldToNewMapping
OldToNewMappingData OldToNewMappingData
OldTriggerInfo OldTriggerInfo