From 865424627db638acdbe4b5d0384d0b9cd34838a5 Mon Sep 17 00:00:00 2001 From: John Naylor Date: Tue, 30 Aug 2022 09:44:44 +0700 Subject: [PATCH] Further code review of port/simd.h Add missing declaration per existing style, and fix a couple typos. Nathan Bossart and Julien Rouhaud Discussion: https://www.postgresql.org/message-id/20220829171712.GA509233%40nathanxps13 Discussion: https://www.postgresql.org/message-id/20220830022636.qrcbcecmhztbxrwa%40jrouhaud --- src/include/port/simd.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/include/port/simd.h b/src/include/port/simd.h index 0ff1549083..74da6e51e0 100644 --- a/src/include/port/simd.h +++ b/src/include/port/simd.h @@ -77,6 +77,9 @@ static inline bool vector8_has(const Vector8 v, const uint8 c); static inline bool vector8_has_zero(const Vector8 v); static inline bool vector8_has_le(const Vector8 v, const uint8 c); static inline bool vector8_is_highbit_set(const Vector8 v); +#ifndef USE_NO_SIMD +static inline bool vector32_is_highbit_set(const Vector32 v); +#endif /* arithmetic operations */ static inline Vector8 vector8_or(const Vector8 v1, const Vector8 v2); @@ -88,7 +91,7 @@ static inline Vector8 vector8_ssub(const Vector8 v1, const Vector8 v2); /* * comparisons between vectors * - * Note: These return a vector rather than booloan, which is why we don't + * Note: These return a vector rather than boolean, which is why we don't * have non-SIMD implementations. */ #ifndef USE_NO_SIMD @@ -275,7 +278,7 @@ vector8_is_highbit_set(const Vector8 v) } /* - * Exactly like vector32_is_highbit_set except for the input type, so it + * Exactly like vector8_is_highbit_set except for the input type, so it * looks at each byte separately. * * XXX x86 uses the same underlying type for 8-bit, 16-bit, and 32-bit