mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-04 17:27:21 +02:00
pg_dump: tests: Correct test condition for invalid databases
For some reason I used not_like = { pg_dumpall_dbprivs => 1, } in the test condition of one of the tests added in inc66a7d75e6
. That doesn't make sense for two reasons: 1) not_like isn't a valid test condition 2) the database should not be dumped in any of the tests. Due to 1), the test achieved its goal, but clearly the formulation is confusing. Instead use like => {}, with a comment explaining why. Reported-by: Peter Eisentraut <peter@eisentraut.org> Discussion: https://postgr.es/m/3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.org Backpatch: 11-, likec66a7d75e6
This commit is contained in:
parent
055f786ea6
commit
881defde94
@ -1913,9 +1913,9 @@ my %tests = (
|
|||||||
CREATE DATABASE regression_invalid;
|
CREATE DATABASE regression_invalid;
|
||||||
UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'regression_invalid'),
|
UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'regression_invalid'),
|
||||||
regexp => qr/^CREATE DATABASE regression_invalid/m,
|
regexp => qr/^CREATE DATABASE regression_invalid/m,
|
||||||
not_like => {
|
|
||||||
pg_dumpall_dbprivs => 1,
|
# invalid databases should never be dumped
|
||||||
},
|
like => {},
|
||||||
},
|
},
|
||||||
|
|
||||||
'CREATE ACCESS METHOD gist2' => {
|
'CREATE ACCESS METHOD gist2' => {
|
||||||
|
Loading…
Reference in New Issue
Block a user