rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix GET DIAGNOSTICS for case of assignment to function's first variable. 

An incorrect and entirely unnecessary "safety check" in exec_stmt_getdiag()
caused the code to treat an assignment to a variable with dno zero as a
no-op.  Unfortunately, that's a perfectly valid dno.  This has been broken
since GET DIAGNOSTICS was invented.  It's not terribly surprising that the
bug went unnoticed for so long, since in most cases you probably wouldn't
use the function's first-created variable (normally its first parameter)
as a GET DIAGNOSTICS target.  Nonetheless, it's broken.  Per bug #6551
from Adam Buraczewski.
This commit is contained in:
Tom Lane 2012-03-22 14:13:17 -04:00
parent e9ce658b62
commit 88a4cb30a4
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/pl/plpgsql/src/pl_exec.c
View File

@ -1447,17 +1447,9 @@ exec_stmt_getdiag(PLpgSQL_execstate *estate, PLpgSQL_stmt_getdiag *stmt)
foreach(lc, stmt->diag_items)
{
PLpgSQL_diag_item *diag_item = (PLpgSQL_diag_item *) lfirst(lc);
PLpgSQL_datum *var;
PLpgSQL_datum *var = estate->datums[diag_item->target];
bool isnull = false;
if (diag_item->target <= 0)
continue;
var = estate->datums[diag_item->target];
if (var == NULL)
continue;
switch (diag_item->kind)
{
case PLPGSQL_GETDIAG_ROW_COUNT: