From 89d52b9a3e3fab3d6876c997370684a8b1c77f3b Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Fri, 11 Jan 2019 17:12:54 -0500 Subject: [PATCH] Free pre-modification HeapTuple in ALTER TABLE ... TYPE ... This was an oversight in commit 3b174b1a3. Per offline gripe from Alvaro Herrera Backpatch to release 11. --- src/backend/commands/tablecmds.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 463894faea..71b2e3f134 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -9747,6 +9747,7 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel, Datum valuesAtt[Natts_pg_attribute]; bool nullsAtt[Natts_pg_attribute]; bool replacesAtt[Natts_pg_attribute]; + HeapTuple newTup; MemSet(valuesAtt, 0, sizeof(valuesAtt)); MemSet(nullsAtt, false, sizeof(nullsAtt)); @@ -9772,8 +9773,10 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel, replacesAtt[Anum_pg_attribute_attmissingval - 1] = true; nullsAtt[Anum_pg_attribute_attmissingval - 1] = false; - heapTup = heap_modify_tuple(heapTup, RelationGetDescr(attrelation), - valuesAtt, nullsAtt, replacesAtt); + newTup = heap_modify_tuple(heapTup, RelationGetDescr(attrelation), + valuesAtt, nullsAtt, replacesAtt); + heap_freetuple(heapTup); + heapTup = newTup; attTup = (Form_pg_attribute) GETSTRUCT(heapTup); } }