mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-04 16:17:18 +02:00
Forbid marking an identity column as nullable.
GENERATED ALWAYS AS IDENTITY implies NOT NULL, but the code failed to complain if you overrode that with "GENERATED ALWAYS AS IDENTITY NULL". One might think the old behavior was a feature, but it was inconsistent because the outcome varied depending on the order of the clauses, so it seems to have been just an oversight. Per bug #16913 from Pavel Boev. Back-patch to v10 where identity columns were introduced. Vik Fearing (minor tweaks by me) Discussion: https://postgr.es/m/16913-3b5198410f67d8c6@postgresql.org
This commit is contained in:
parent
3580b4a0cd
commit
8a22977766
@ -839,6 +839,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
|
||||
column</firstterm>. It will have an implicit sequence attached to it
|
||||
and the column in new rows will automatically have values from the
|
||||
sequence assigned to it.
|
||||
Such a column is implicitly <literal>NOT NULL</literal>.
|
||||
</para>
|
||||
|
||||
<para>
|
||||
|
@ -716,7 +716,17 @@ transformColumnDefinition(CreateStmtContext *cxt, ColumnDef *column)
|
||||
|
||||
column->identity = constraint->generated_when;
|
||||
saw_identity = true;
|
||||
|
||||
/* An identity column is implicitly NOT NULL */
|
||||
if (saw_nullable && !column->is_not_null)
|
||||
ereport(ERROR,
|
||||
(errcode(ERRCODE_SYNTAX_ERROR),
|
||||
errmsg("conflicting NULL/NOT NULL declarations for column \"%s\" of table \"%s\"",
|
||||
column->colname, cxt->relation->relname),
|
||||
parser_errposition(cxt->pstate,
|
||||
constraint->location)));
|
||||
column->is_not_null = true;
|
||||
saw_nullable = true;
|
||||
break;
|
||||
}
|
||||
|
||||
|
@ -491,3 +491,16 @@ CREATE TABLE itest14 (id serial);
|
||||
ALTER TABLE itest14 ALTER id DROP DEFAULT;
|
||||
ALTER TABLE itest14 ALTER id ADD GENERATED BY DEFAULT AS IDENTITY;
|
||||
INSERT INTO itest14 (id) VALUES (DEFAULT);
|
||||
-- Identity columns must be NOT NULL (cf bug #16913)
|
||||
CREATE TABLE itest15 (id integer GENERATED ALWAYS AS IDENTITY NULL); -- fail
|
||||
ERROR: conflicting NULL/NOT NULL declarations for column "id" of table "itest15"
|
||||
LINE 1: ...ABLE itest15 (id integer GENERATED ALWAYS AS IDENTITY NULL);
|
||||
^
|
||||
CREATE TABLE itest15 (id integer NULL GENERATED ALWAYS AS IDENTITY); -- fail
|
||||
ERROR: conflicting NULL/NOT NULL declarations for column "id" of table "itest15"
|
||||
LINE 1: CREATE TABLE itest15 (id integer NULL GENERATED ALWAYS AS ID...
|
||||
^
|
||||
CREATE TABLE itest15 (id integer GENERATED ALWAYS AS IDENTITY NOT NULL);
|
||||
DROP TABLE itest15;
|
||||
CREATE TABLE itest15 (id integer NOT NULL GENERATED ALWAYS AS IDENTITY);
|
||||
DROP TABLE itest15;
|
||||
|
@ -323,3 +323,12 @@ CREATE TABLE itest14 (id serial);
|
||||
ALTER TABLE itest14 ALTER id DROP DEFAULT;
|
||||
ALTER TABLE itest14 ALTER id ADD GENERATED BY DEFAULT AS IDENTITY;
|
||||
INSERT INTO itest14 (id) VALUES (DEFAULT);
|
||||
|
||||
-- Identity columns must be NOT NULL (cf bug #16913)
|
||||
|
||||
CREATE TABLE itest15 (id integer GENERATED ALWAYS AS IDENTITY NULL); -- fail
|
||||
CREATE TABLE itest15 (id integer NULL GENERATED ALWAYS AS IDENTITY); -- fail
|
||||
CREATE TABLE itest15 (id integer GENERATED ALWAYS AS IDENTITY NOT NULL);
|
||||
DROP TABLE itest15;
|
||||
CREATE TABLE itest15 (id integer NOT NULL GENERATED ALWAYS AS IDENTITY);
|
||||
DROP TABLE itest15;
|
||||
|
Loading…
Reference in New Issue
Block a user