mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-29 22:27:19 +02:00
Another fix to relmapper race condition.
In previous commit, I missed that relmap_redo() was also not acquiring the RelationMappingLock. Thanks to Thomas Munro for pointing that out. Backpatch-through: 9.6, like previous commit. Discussion: https://www.postgresql.org/message-id/CA%2BhUKGLev%3DPpOSaL3WRZgOvgk217et%2BbxeJcRr4eR-NttP1F6Q%40mail.gmail.com
This commit is contained in:
parent
caac196507
commit
8b01a403c5
5
src/backend/utils/cache/relmapper.c
vendored
5
src/backend/utils/cache/relmapper.c
vendored
@ -1030,12 +1030,13 @@ relmap_redo(XLogReaderState *record)
|
|||||||
* preserve files, either.
|
* preserve files, either.
|
||||||
*
|
*
|
||||||
* There shouldn't be anyone else updating relmaps during WAL replay,
|
* There shouldn't be anyone else updating relmaps during WAL replay,
|
||||||
* so we don't bother to take the RelationMappingLock. We would need
|
* but grab the lock to interlock against load_relmap_file().
|
||||||
* to do so if load_relmap_file needed to interlock against writers.
|
|
||||||
*/
|
*/
|
||||||
|
LWLockAcquire(RelationMappingLock, LW_EXCLUSIVE);
|
||||||
write_relmap_file((xlrec->dbid == InvalidOid), &newmap,
|
write_relmap_file((xlrec->dbid == InvalidOid), &newmap,
|
||||||
false, true, false,
|
false, true, false,
|
||||||
xlrec->dbid, xlrec->tsid, dbpath);
|
xlrec->dbid, xlrec->tsid, dbpath);
|
||||||
|
LWLockRelease(RelationMappingLock);
|
||||||
|
|
||||||
pfree(dbpath);
|
pfree(dbpath);
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user