From 8bdd6f563aa2456de602e78991e6a9f61b8ec86d Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Thu, 20 May 2021 08:03:15 -0400 Subject: [PATCH] Use a more portable way to get the version string in PostgresNode Older versions of perl on Windows don't like the list form of pipe open, and perlcritic doesn't like the string form of open, so we avoid both with a simpler formulation using qx{}. Per complaint from Amit Kapila. --- src/test/perl/PostgresNode.pm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm index f7088667a4..c09a735dae 100644 --- a/src/test/perl/PostgresNode.pm +++ b/src/test/perl/PostgresNode.pm @@ -1248,10 +1248,8 @@ sub _set_pg_version local %ENV = $self->_get_env(); # We only want the version field - open my $fh, "-|", $pg_config, "--version" - or BAIL_OUT("$pg_config failed: $!"); - my $version_line = <$fh>; - close $fh or die; + my $version_line = qx{$pg_config --version}; + BAIL_OUT("$pg_config failed: $!") if $?; $self->{_pg_version} = PostgresVersion->new($version_line);