rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix possible NULL-pointer-deference in backup_compression.c. 

Per Coverity and Tom Lane. Reviewed by Tom Lane and Justin Pryzby.

Discussion: http://postgr.es/m/384291.1648403267@sss.pgh.pa.us
This commit is contained in:
Robert Haas 2022-03-30 15:53:08 -04:00
parent 027fa0fd72
commit 8e053dc6df
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/common/backup_compression.c
View File

@ -191,8 +191,16 @@ parse_bc_specification(bc_algorithm algorithm, char *specification,
if (value != NULL)
pfree(value);
/* If we got an error or have reached the end of the string, stop. */
if (result->parse_error != NULL || *kwend == '\0' || *vend == '\0')
/*
* If we got an error or have reached the end of the string, stop.
*
* If there is no value, then the end of the keyword might have been
* the end of the string. If there is a value, then the end of the
* keyword cannot have been the end of the string, but the end of the
* value might have been.
*/
if (result->parse_error != NULL ||
(vend == NULL ? *kwend == '\0' : *vend == '\0'))
break;
/* Advance to next entry and loop around. */