From 91d568e9bbcd2c60e6ca36b2e5ef5404dfec62f8 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 12 May 2006 22:44:36 +0000 Subject: [PATCH] Fix the sense of the test on DH_check()'s return value. This was preventing custom-generated DH parameters from actually being used by the server. Found by Michael Fuhr. --- src/backend/libpq/be-secure.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/libpq/be-secure.c b/src/backend/libpq/be-secure.c index 8a4def4e11..022c4f0b69 100644 --- a/src/backend/libpq/be-secure.c +++ b/src/backend/libpq/be-secure.c @@ -11,7 +11,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/libpq/be-secure.c,v 1.69 2006/05/06 02:24:39 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/libpq/be-secure.c,v 1.70 2006/05/12 22:44:36 tgl Exp $ * * Since the server static private key ($DataDir/server.key) * will normally be stored unencrypted so that the database @@ -524,7 +524,7 @@ load_dh_file(int keylength) /* make sure the DH parameters are usable */ if (dh != NULL) { - if (DH_check(dh, &codes)) + if (DH_check(dh, &codes) == 0) { elog(LOG, "DH_check error (%s): %s", fnbuf, SSLerrmessage()); return NULL;