Default to dynamic_shared_memory_type=sysv on Solaris.

POSIX shm_open() can sleep for a long time and fail spuriously because
of contention on an internal lock file on Solaris (and presumably
illumos).  Commit 389869af fixed the main problem with this, namely that
we could crash, but it's now clear that "posix" is not a good default.

Therefore, choose "sysv" at initdb time on Solaris and illumos.  Other
choices are still available by editing the postgresql.conf file.

Back-patch only to 15, because contention is much less likely further
back, and it doesn't seem like a good idea to change this in released
branches.  This should clear up the failures on build farm animal
margay.

Discussion: https://postgr.es/m/CA%2BhUKGKqKrCV5xKWfh9rnm%3Do%3DDwZLTLtnsj_XpUi9g5%3DV%2B9oyg%40mail.gmail.com
This commit is contained in:
Thomas Munro 2022-07-02 16:06:47 +12:00
parent 0507977aa4
commit 94ebf8117c
3 changed files with 6 additions and 3 deletions

View File

@ -2036,7 +2036,7 @@ include_dir 'conf.d'
and <literal>mmap</literal> (to simulate shared memory using
memory-mapped files stored in the data directory).
Not all values are supported on all platforms; the first supported
option is the default for that platform. The use of the
option is usually the default for that platform. The use of the
<literal>mmap</literal> option, which is not the default on any platform,
is generally discouraged because the operating system may write
modified pages back to disk repeatedly, increasing system I/O load;

View File

@ -147,7 +147,7 @@
# sysv
# windows
# (change requires restart)
#dynamic_shared_memory_type = posix # the default is the first option
#dynamic_shared_memory_type = posix # the default is usually the first option
# supported by the operating system:
# posix
# sysv

View File

@ -842,11 +842,14 @@ set_null_conf(void)
* segment in dsm_impl.c; if it doesn't work, we assume it won't work for
* the postmaster either, and configure the cluster for System V shared
* memory instead.
*
* We avoid choosing Solaris's implementation of shm_open() by default. It
* can sleep and fail spuriously under contention.
*/
static const char *
choose_dsm_implementation(void)
{
#ifdef HAVE_SHM_OPEN
#if defined(HAVE_SHM_OPEN) && !defined(__sun__)
int ntries = 10;
pg_prng_state prng_state;