From 950e236e50691d80e50d0aa18b66d1f459105558 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Fri, 29 Sep 2023 10:34:18 +0900 Subject: [PATCH] doc: Fix descriptions related to the handling of non-ASCII characters Since 45b1a67a0fcb, non-printable ASCII characters do not show up in various configuration paths as question marks, but as hexadecimal escapes. The documentation was not updated to reflect that. Author: Hayato Kuroda Reviewed-by: Jian He, Tom Lane, Karl O. Pinc, Peter Smith Discussion: https://postgr.es/m/TYAPR01MB586631D0961BF9C44893FAB1F523A@TYAPR01MB5866.jpnprd01.prod.outlook.com Backpatch-through: 16 --- doc/src/sgml/config.sgml | 15 +++++++++------ doc/src/sgml/postgres-fdw.sgml | 6 +++--- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 4647539e40..126c147fc6 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -7012,8 +7012,9 @@ local0.* /var/log/postgresql and included in CSV log entries. It can also be included in regular log entries via the parameter. Only printable ASCII characters may be used in the - application_name value. Other characters will be - replaced with question marks (?). + application_name value. + Other characters are replaced with C-style hexadecimal escapes. @@ -8009,10 +8010,12 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv; The name can be any string of less than NAMEDATALEN characters (64 characters in a standard build). Only printable ASCII characters may be used in the - cluster_name value. Other characters will be - replaced with question marks (?). No name is shown - if this parameter is set to the empty string '' (which is - the default). This parameter can only be set at server start. + cluster_name value. + Other characters are replaced with C-style hexadecimal escapes. + No name is shown if this parameter is set to the empty string + '' (which is the default). + This parameter can only be set at server start. diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml index 5062d712e7..c177fd41bc 100644 --- a/doc/src/sgml/postgres-fdw.sgml +++ b/doc/src/sgml/postgres-fdw.sgml @@ -1067,9 +1067,9 @@ postgres=# SELECT postgres_fdw_disconnect_all(); of any length and contain even non-ASCII characters. However when it's passed to and used as application_name in a foreign server, note that it will be truncated to less than - NAMEDATALEN characters and anything other than - printable ASCII characters will be replaced with question - marks (?). + NAMEDATALEN characters. + Anything other than printable ASCII characters are replaced with C-style hexadecimal escapes. See for details.