rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Suppress compiler warning in pub_collist_to_bitmapset(). 

A fair percentage of the buildfarm doesn't recognize that oldcxt
won't be used uninitialized; silence those warnings by initializing it.

While here, upgrade the function's thoroughly inadequate header comment.

Oversight in 923def9a5, per buildfarm.
This commit is contained in:
Tom Lane 2022-03-26 11:53:37 -04:00
parent 923def9a53
commit 979cd655c1
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/catalog/pg_publication.c
View File

@ -592,7 +592,11 @@ publication_translate_columns(Relation targetrel, List *columns,
}
/*
* Transform the column list (represented by an array) to a bitmapset.
* Transform a column list (represented by an array Datum) to a bitmapset.
*
* If columns isn't NULL, add the column numbers to that set.
*
* If mcxt isn't NULL, build the bitmapset in that context.
*/
Bitmapset *
pub_collist_to_bitmapset(Bitmapset *columns, Datum pubcols, MemoryContext mcxt)
@ -601,7 +605,7 @@ pub_collist_to_bitmapset(Bitmapset *columns, Datum pubcols, MemoryContext mcxt)
ArrayType *arr;
int nelems;
int16 *elems;
MemoryContext oldcxt;
MemoryContext oldcxt = NULL;
/*
* If an existing bitmap was provided, use it. Otherwise just use NULL